-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KodaDot - AssetsHub NFT indexer - Milestone 1 #1864
Conversation
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/polkadot-nft-assets-hub-indexer-by-kodadot/3528/1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the thorough application, @yangwao! I will share it with the rest of the committee. I just have two questions:
- Since you mentioned that KodaDot is already using the indexer, could you expand on which parts of the project are already implemented and which are still work in progress?
- To simplify the evaluation, could you compress the list of deliverables? We don't need a separate deliverable for every event. For example, 3a and b, 4a to f and 6a to e could be one deliverable each.
You can have a realtime check here - https://github.com/kodadot/stick/milestone/1
From our experience, the best is to have micro deliverables that the w3f reviewer can quickly evaluate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the application, and sorry for the delay here. I'm generally happy to support the project, but could you reduce the price? The current FTE of 4, for example, seems too high to me, considering your current progress as well as the fact that so far, only three people contributed to the project. Reducing the grant to a level 2 project would also make it easier to accept it ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with David. Twelve person months seems a lot for the scope.
Are you planning to make any further changes to the application, @yangwao, or should we continue reviewing as is? |
There will be more people working on this.
Yes, for now, it makes sense to split.
Will be updating this week. |
Thanks @yangwao feel free to ping us when we should take another look at it. |
any updates, @yangwao? |
Sure. I've been OOO, will look at the upcoming days |
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read and hereby sign the Contributor License Agreement. |
Hey, @semuelle @keeganquigley @Noc2, I've split our proposal into Milestones. Ref
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, @yangwao. Please see some questions below.
applications/kodadot_assethub_nft_indexer_statemine_statemint.md
Outdated
Show resolved
Hide resolved
| 9. | Metadata Support for Fungible Assets | Implement a handler to add metadata to a fungible asset event from the chain. | | ||
| 9c. | Fungible Asset Allowlist Setup |Setting up allows list-based indexing of fungible assets. | | ||
| 10a. | Data Views Development |Construction of data views for efficient access to indexed data. | | ||
| 10b. | Implementing Metadata Caching Layer |Develop and retry IPFS metadata if un-indexed by 7j. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does 'unindexed' mean here? Unpinned?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this means that we will store those data if particular IPFS hashes are not pinned by original author for better UX.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does 'unindexed' mean here? Unpinned?
We have come up eager approach of fetching metadata from ipfs (aka to index). If indexer fails to do that in 8 seconds metadata are unidexed and we try again after some period of time?
This is usefull because end users of this indexer does not nees to suffer high costs of IPFS gateways.
applications/kodadot_assethub_nft_indexer_statemine_statemint.md
Outdated
Show resolved
Hide resolved
Please ping me here when the changes relevant to my requests have been made, @yangwao. |
@semuelle please have check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yangwao. Thanks for the updates. However, I am slightly confused as the issues listed in the M1 tracker have been closed for six weeks, and the commits referenced in them are largely from April and May. Since we don't do retroactive funding, I'd suggest you apply for M2 instead.
Hello @semuelle.
Yes that was a proof-of-work that we are able to deliver good quality software.
Yes, all this is implemented using FireSquid technology that would come to EOL in 3-4 months. FireSquid vs. ArrowSquid aren't the same The ArrowSquid is using a batch processor, that requires totally different data handling as FireSquid. Due to the nature of the ArrowSquid we are able do the processing more effectively but need to rewrite the code from scratch. TL;DR Prior this proposal the M1 was aimed as a proof of concept to present the successful delivery by our team. We aim to use latest tech (ArrowSquid) that requires reimplemetation of the current indexer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, @yangwao, and sorry for the late reply. Could you add the details of your previous comment regarding ArrowSquid into the application? Currently, it's not mentioned at all. Also, you removed the 5k USD allocation as deliverable, but the total costs remained the same. I would have assumed that it would be reduced correspondingly.
@semuelle is the proposal ready to be merged? |
Hello @semuelle @keeganquigley please have check |
I have read and hereby sign the Contributor License Agreement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vikiival @yangwao although looks like the application is still missing an Overview section. Can you add this in?
Also, the numbering in the milestone tables is missing 6, therefore it doesn't make sense as is. Can you fix the numbering scheme and perhaps consolidate some of the deliverables so that there aren't so many? For example, 4a. - 4f. could probably be combined into one section, as well as 7a. - 7k. Also section 9 doesn't follow the same letter scheme that the rest of the deliverables have.
📝 unify deliverables per assethub indexer
Hey thanks for your assumption @semuelle, it was supposed to be removed as residues from the first version of the proposal, we've realized that implementation costs are slightly higher in ArrowSquid, than we've anticipated, thus we are taking max allowance on this stage to at least cover our implementation costs.
It's added now.
Improved now. Let us know @keeganquigley when you review it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @yangwao I think it would be great to have an indexer for AssetHub. Also based on Kodadot's standing in the community I'm willing to go forward with it. I will mark the application as ready for review and ping the rest of the committee.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, @yangwao. I am also willing to go ahead with it.
Congratulations and welcome to the Web3 Foundation Grants Program! Please refer to our Milestone Delivery repository for instructions on how to submit milestones and invoices, our FAQ for frequently asked questions and the support section of our README for more ways to find answers to your questions. |
Project Abstract
The AssetHub Indexer is a GraphQL service designed to streamline the interaction with Uniques, NFT non-fungible assets, and fungible assets on AssetHubs (Statemine/Statemint). This service is specifically tailored to serve as a robust data layer for NFT-oriented dApps, leveraging the simplicity of GraphQL and REST API.
In the current landscape, developers face challenges interacting with Uniques and Assets on Statemine due to the complexity and time-consuming nature of querying fungible and non-fungible assets on AssetHub. AssetHub Indexer aims to address these challenges by providing a user-friendly GraphQL interface, thus reducing the time and effort required to query these assets.
The key advantages of the AssetHub Indexer include
Furthermore, the AssetHub Indexer is a completely decentralized, open-source solution that respects user privacy by not collecting user data.
By reducing the time required to query assets and providing a more user-friendly interface, the AssetHub Indexer aims to foster the growth and development of the Web 3.0 ecosystem in Polkadot.
Grant level
Application Checklist
kodadot_assethub_nft_indexer_statemine_statemint.md
).