KodaDot: AssetHub NFT indexer M1

[vikiival]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• This pull request is being made by the same account as the accepted application. - Original was opened by @yangwao, we are both founders of KodaDot
• I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
• In case of acceptance, an invoice must be submitted and the payment will be transferred to the Polkadot/fiat account provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1864 < please fill this in with the PR number of your application.

[yangwao]

• This pull request is being made by the same account as the accepted application. - Original was opened by @yangwao, we are both founders of KodaDot

Hello, @PieWol, should I open PR under my account, or is this one ok?

[PieWol]

• This pull request is being made by the same account as the accepted application. - Original was opened by @yangwao, we are both founders of KodaDot

Hello, @PieWol, should I open PR under my account, or is this one ok?

Hey @vikiival this is fine :)

[PieWol]

Hey @vikiival ,
which branch should I use for testing, which readme to follow? arrow stick or main?

Trying to "quickly running the sample" of the arrow-stick branch readme I get this error: pastebin . Any idea whats going wrong?

[vikiival]

which branch should I use for testing

arrow-stick as linked in the readme

Trying to "quickly running the sample" of the arrow-stick branch readme I get this erro

Yes there is update db missing, we forgot to add it to the readme:

npx squid-typeorm-migration apply

https://github.com/kodadot/stick/blob/5cdeec1139e3a68fa2ecec1427d4b9d02b2d152a/justfile#L47

https://docs.subsquid.io/sdk/troubleshooting/persisting-data/

Added in kodadot/stick@3aaf029

[PieWol]

@vikiival as I had this error on the "just process" step shouldn't the "just migrate" step be executed before "just process"? Right now it's the other way around in the readme. Good news is that it works now. Thanks for the quick fix :)

[vikiival]

Right now it's the other way around in the readme

Will fix, thanks for the mention

Added in kodadot/stick@1cda35b

[yangwao]

Good news is that it works now. Thanks for the quick fix :)

Hey, excuse me for being pushy, but are there any updates from your side, @PieWol ?
We need this to be approved, so we can merge few outstanding internal PRs for users experience on kodadot.xyz
Namely

• 🎉 🏹 🦑 Hello kodadot/stick#194
• feat: Price sort by logic kodadot/nft-gallery#8920

Thank you for your swift reply ahead.

[PieWol]

Hey @yangwao sorry for the delay,
I'll have your evaluation ready tomorrow.

[PieWol]

Hey @vikiival ,
the testing deliverable stated the following.

Testing will cover major functionality with unit tests and provide a guide for executing these tests.

Where do I find the testing guidelines and the unit tests? The current link doesn't point to a guide.

[vikiival]

Hey @vikiival , the testing deliverable stated the following.

Testing will cover major functionality with unit tests and provide a guide for executing these tests.

Where do I find the testing guidelines and the unit tests? The current link doesn't point to a guide.

Hello,
we follow the classical convention of running the tests

other tests are part of hyperdata

TL;DR all tests are located in the tests directory and to run them one must use npm run test

but we will add that to the readme

[PieWol]

Hey @vikiival this is my current evaluation for this project. I have a few questions in the notes and listed things that should be added. Looking forward to your response and changes.

[vikiival]

Hey @vikiival this is my current evaluation for this project. I have a few questions in the notes and listed things that should be added. Looking forward to your response and changes.

Replied for all. Will add better documentation, thanks for the feedback. Hope I clarified all your questions.

#1133 (comment)

[vikiival]

@PieWol can we proceed? 🥺

[PieWol]

@PieWol can we proceed? 🥺

As I said, team needs to review and merge. I can't speed up the process for you at this point. Please give us a little time.

[semuelle]

Thanks, @vikiival & @yangwao. I just confirmed the evaluation. Your milestone is hereby approved.

[github-actions]

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

[vikiival]

Hey @semuelle I have already sent invoice on 30.01.2024.
Can we proceed with that one or should I make a new one?

Guess @keeganquigley was replying me.

Edit:
Thank you very much for the approval and smooth process.
Thanks for making the ecosystem awesome! ❤️