-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delivery: Project Aurras MVP - Phase 1 - Milestone 2 & Milestone 3 #255
Delivery: Project Aurras MVP - Phase 1 - Milestone 2 & Milestone 3 #255
Conversation
Let us know once it’s ready for review. |
Sure @Noc2 . We need to update the payment address. Can we raise a new pull request in applications repo? |
@MuhammedIrfan that's the correct procedure 👍 |
Thank you @alxs |
@Noc2 Kindly look into the delivery. The Article will be published to medium post approval from the grants team and Will be updated in the delivery document with the link to the medium article. Thank you |
Thanks for the reminder, @MuhammedIrfan. We have a bit of a backlog, but someone will look into it very soon. |
We understand @semuelle . Thank you. |
@MuhammedIrfan I've had a first go at your milestone 2 & 3. I've ran into a few issues, you can check these directly in my evaluation notes for M2 & M3. Please let me know once you've addressed the questions there, so I could proceed with the process. Thanks for all the work so far! |
@mmagician Thank you very much. We will soon fix the issues and update you as soon as possible. |
@mmagician We have fixed the issues you have pointed. Kindly find the issues and respective PR Issue HugoByte/aurras#14 Issue HugoByte/aurras#12 Issue HugoByte/aurras#13 With Regards to Automated Integration Testing, We tried to implement but we stumbled upon many issues, We will implement it in the course of further development. Kindly review the changes |
@mmagician Please find below the link to article that has been published as part of the milestone. |
@MuhammedIrfan Thanks for the changes, they look good. However now I'm struggling to deploy your actions with the
It seems that all wsk commands are failing for me now.
Also, when trying to test the push-notification action with Lastly, I have just updated my local docker setup to the latest engine and uncovered some incompatibility with the env variables, I opened a PR. |
@mmagician Thank you for reviewing our delivery and apologies for the obstacles faced while testing.
This possibly can be due to openwhisk not yet started functioning completely. After we run docker-compose the controller, invoker and Kafka provider will wait for couchdb-setup to stop as the couchdb-setup would be migrating the db for controller and invoker. Thank you for pointing it out, It is usually not noticeable, but due to some reason if the container takes time to start we will encounter this issue. I will add this to the docker-compose deployment repo. Please keep an eye on the logs folder, We can be sure if the openwhisk started only when we find the below logs
Issue: HugoByte/aurras#18
TEST_DEVICE_TOKEN refers to push notification token, the token can be generated from the client for which the client is registered with the Issue: HugoByte/aurras#17
We highly appreciate your contribution and Thank you for supporting our project, We are looking forward to more contributions and to make this a community-driven project. |
Great, I'll wait for you to let me know once you're done. |
@mmagician Kindly review Issue: HugoByte/aurras#18 Issue: HugoByte/aurras#17 |
@MuhammedIrfan Apologies for a delayed response. I have finished your evaluation and can happily say that both milestones are accepted now. |
I've noticed that the numbers on your invoice don't quite match: you had 0.58 for M2 and 0.33 for M3, but have written 0.95 BTC as a total. Please amend that and send us a new, corrected invoice. |
Thank you very much @mmagician.
I sincerely apologize for the mistake. We have sent forward the corrected invoice. Please check. |
Great. I just forwarded the new invoice internally. |
Thank you @Noc2 |
hi @MuhammedIrfan we transferred the payment today. |
Hi @RouvenP, You meant about the test payment? We have received 0.01 BTC @ https://www.blockchain.com/btc/tx/23eec7c9e145ed5fa2a154336035e418fabad0f6e0cb661a3de9fb93f7040e4c |
hi @MuhammedIrfan exactly - thanks for confirming. We'll send the remainder next week. |
@RouvenP Sure |
hi @MuhammedIrfan we transferred the remainder today. |
@RouvenP I confirm that we have received. Thank you. |
* substrate identity directory * substrate identity directory * added 0a to 0d deliveries to milestone 1 * price changed Co-authored-by: dark64 <[email protected]>
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#163