Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delivery: Project Aurras MVP - Phase 1 - Milestone 2 & Milestone 3 #255

Merged
merged 5 commits into from
Oct 19, 2021

Conversation

MuhammedIrfan
Copy link
Contributor

@MuhammedIrfan MuhammedIrfan commented Aug 16, 2021

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#163

@Noc2
Copy link
Collaborator

Noc2 commented Aug 16, 2021

Let us know once it’s ready for review.

@MuhammedIrfan
Copy link
Contributor Author

Let us know once it’s ready for review.

Sure @Noc2 . We need to update the payment address. Can we raise a new pull request in applications repo?

@alxs
Copy link
Contributor

alxs commented Aug 17, 2021

@MuhammedIrfan that's the correct procedure 👍

@MuhammedIrfan
Copy link
Contributor Author

@MuhammedIrfan that's the correct procedure 👍

Thank you @alxs

@MuhammedIrfan MuhammedIrfan marked this pull request as ready for review September 1, 2021 20:17
@MuhammedIrfan
Copy link
Contributor Author

MuhammedIrfan commented Sep 1, 2021

@Noc2 Kindly look into the delivery. The Article will be published to medium post approval from the grants team and Will be updated in the delivery document with the link to the medium article.

Thank you

@semuelle
Copy link
Member

semuelle commented Sep 2, 2021

Thanks for the reminder, @MuhammedIrfan. We have a bit of a backlog, but someone will look into it very soon.

@MuhammedIrfan
Copy link
Contributor Author

Thanks for the reminder, @MuhammedIrfan. We have a bit of a backlog, but someone will look into it very soon.

We understand @semuelle . Thank you.

@mmagician mmagician self-assigned this Sep 6, 2021
@mmagician
Copy link
Contributor

@MuhammedIrfan I've had a first go at your milestone 2 & 3. I've ran into a few issues, you can check these directly in my evaluation notes for M2 & M3. Please let me know once you've addressed the questions there, so I could proceed with the process. Thanks for all the work so far!

@MuhammedIrfan
Copy link
Contributor Author

@MuhammedIrfan I've had a first go at your milestone 2 & 3. I've ran into a few issues, you can check these directly in my evaluation notes for M2 & M3. Please let me know once you've addressed the questions there, so I could proceed with the process. Thanks for all the work so far!

@mmagician Thank you very much. We will soon fix the issues and update you as soon as possible.

@MuhammedIrfan
Copy link
Contributor Author

@mmagician We have fixed the issues you have pointed. Kindly find the issues and respective PR

Issue HugoByte/aurras#14
PR HugoByte/aurras#15

Issue HugoByte/aurras#12
PR HugoByte/aurras#16

Issue HugoByte/aurras#13
Commits 1, 2

With Regards to Automated Integration Testing, We tried to implement but we stumbled upon many issues, We will implement it in the course of further development.

Kindly review the changes

@MuhammedIrfan
Copy link
Contributor Author

@mmagician Please find below the link to article that has been published as part of the milestone.

https://medium.com/hugobyte/completion-of-aurras-mvp-a-middleware-for-the-web3-ecosystem-ee4f666be6aa

@mmagician
Copy link
Contributor

@MuhammedIrfan Thanks for the changes, they look good.

However now I'm struggling to deploy your actions with the deploy.sh script. Currently it is failing with:

error: Invalid argument(s). Unable to get action 'push-notification': The connection failed, or timed out. (HTTP status code 502)

It seems that all wsk commands are failing for me now.
I have just updated all the containers with docker-compose pull and started openwhisk seemingly successfully.
docker ps output:

...
22da17f33b94   openwhisk/apigateway:nightly           "/usr/bin/dumb-init …"   2 minutes ago    Up 2 minutes                    0.0.0.0:80->80/tcp, 0.0.0.0:9000->9000/tcp, 0.0.0.0:31001->31001/tcp, 8423/tcp, 0.0.0.0:9090->8080/tcp   openwhisk-apigateway-1
...

Also, when trying to test the push-notification action with cargo test --all-features, it's failing because of missing TEST_DEVICE_TOKEN, but I actually have no clue what this relates to or how to get it. Could you add appropriate instructions please?


Lastly, I have just updated my local docker setup to the latest engine and uncovered some incompatibility with the env variables, I opened a PR.

@MuhammedIrfan
Copy link
Contributor Author

@mmagician Thank you for reviewing our delivery and apologies for the obstacles faced while testing.

However now I'm struggling to deploy your actions with the deploy.sh script. Currently it is failing with:

error: Invalid argument(s). Unable to get action 'push-notification': The connection failed, or timed out. (HTTP status code 502)

It seems that all wsk commands are failing for me now. I have just updated all the containers with docker-compose pull and started openwhisk seemingly successfully. docker ps output:

...
22da17f33b94   openwhisk/apigateway:nightly           "/usr/bin/dumb-init …"   2 minutes ago    Up 2 minutes                    0.0.0.0:80->80/tcp, 0.0.0.0:9000->9000/tcp, 0.0.0.0:31001->31001/tcp, 8423/tcp, 0.0.0.0:9090->8080/tcp   openwhisk-apigateway-1
...

This possibly can be due to openwhisk not yet started functioning completely. After we run docker-compose the controller, invoker and Kafka provider will wait for couchdb-setup to stop as the couchdb-setup would be migrating the db for controller and invoker. Thank you for pointing it out, It is usually not noticeable, but due to some reason if the container takes time to start we will encounter this issue. I will add this to the docker-compose deployment repo.

Please keep an eye on the logs folder, We can be sure if the openwhisk started only when we find the below logs

  • logs/controller.log
  • logs/invoker.log
  • logs/kafka-provider.log

Issue: HugoByte/aurras#18

Also, when trying to test the push-notification action with cargo test --all-features, it's failing because of missing TEST_DEVICE_TOKEN, but I actually have no clue what this relates to or how to get it. Could you add appropriate instructions please?

TEST_DEVICE_TOKEN refers to push notification token, the token can be generated from the client for which the client is registered with the FIREBASE_API_KEY, ie in our case client is Substrate Push Notification. Once you start Substrate Push notification and upon opening the Register Balance Notification modal, you can get the Push Notification Token from the input box. It has been kept read only as it is a generated token and to avoid mistyping it. We will add instructions for it finding the token.

Issue: HugoByte/aurras#17

Lastly, I have just updated my local docker setup to the latest engine and uncovered some incompatibility with the env variables, I opened a PR.

We highly appreciate your contribution and Thank you for supporting our project, We are looking forward to more contributions and to make this a community-driven project.

@mmagician
Copy link
Contributor

Great, I'll wait for you to let me know once you're done.

@MuhammedIrfan
Copy link
Contributor Author

@mmagician
Copy link
Contributor

@MuhammedIrfan Apologies for a delayed response. I have finished your evaluation and can happily say that both milestones are accepted now.
You can find the full evaluations here: M2 & M3.

@mmagician mmagician merged commit 57edf3c into w3f:master Oct 19, 2021
@mmagician
Copy link
Contributor

I've noticed that the numbers on your invoice don't quite match: you had 0.58 for M2 and 0.33 for M3, but have written 0.95 BTC as a total. Please amend that and send us a new, corrected invoice.

@MuhammedIrfan
Copy link
Contributor Author

@MuhammedIrfan Apologies for a delayed response. I have finished your evaluation and can happily say that both milestones are accepted now. You can find the full evaluations here: M2 & M3.

Thank you very much @mmagician.

I've noticed that the numbers on your invoice don't quite match: you had 0.58 for M2 and 0.33 for M3, but have written 0.95 BTC as a total. Please amend that and send us a new, corrected invoice.

I sincerely apologize for the mistake. We have sent forward the corrected invoice. Please check.

@Noc2
Copy link
Collaborator

Noc2 commented Oct 20, 2021

Great. I just forwarded the new invoice internally.

@MuhammedIrfan
Copy link
Contributor Author

Great. I just forwarded the new invoice internally.

Thank you @Noc2

@RouvenP
Copy link

RouvenP commented Oct 28, 2021

hi @MuhammedIrfan we transferred the payment today.

@MuhammedIrfan
Copy link
Contributor Author

hi @MuhammedIrfan we transferred the payment today.

Hi @RouvenP,

You meant about the test payment?

We have received 0.01 BTC @ https://www.blockchain.com/btc/tx/23eec7c9e145ed5fa2a154336035e418fabad0f6e0cb661a3de9fb93f7040e4c

@RouvenP
Copy link

RouvenP commented Oct 28, 2021

hi @MuhammedIrfan exactly - thanks for confirming. We'll send the remainder next week.

@MuhammedIrfan
Copy link
Contributor Author

hi @MuhammedIrfan exactly - thanks for confirming. We'll send the remainder next week.

@RouvenP Sure

@RouvenP
Copy link

RouvenP commented Nov 5, 2021

hi @MuhammedIrfan we transferred the remainder today.

@MuhammedIrfan
Copy link
Contributor Author

hi @MuhammedIrfan we transferred the remainder today.

@RouvenP I confirm that we have received. Thank you.

failfmi pushed a commit to LimeChain/Grant-Milestone-Delivery that referenced this pull request Sep 26, 2022
* substrate identity directory

* substrate identity directory

* added 0a to 0d deliveries to milestone 1

* price changed

Co-authored-by: dark64 <[email protected]>
@MuhammedIrfan MuhammedIrfan deleted the aurras-mvp-delivery-milestone-2-3 branch February 8, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants