subsmt_milestone_1 #1228
Merged
subsmt_milestone_1 #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semuelle
requested changes
Dec 2, 2024
There was a problem hiding this comment.
Hi @YanOctavian. Thanks for the delivery, but the PR is currently editing our application template as well; could you undo those changes?
@semuelle Thank you for your reminder. I will update it as soon as possible. |
semuelle
requested changes
Dec 2, 2024
There was a problem hiding this comment.
I am trying to compile the project locally, but I run into issues. First, cargo build failed because the members folders are case sensitive (SMT, not smt). Then, it fails with the following error message. This also happens using docker build (docker compose works, though). Could you check?
Compiling sp-runtime v31.0.1 (https://github.com/paritytech/polkadot-sdk?branch=release-polkadot-v1.14.0#778e9d15)
Compiling alloc-stdlib v0.2.2
Compiling num-bigint v0.4.6
Compiling const-random v0.1.18
Compiling scale-decode v0.11.1
error[E0277]: the trait bound `generic::header::Header<Number, Hash>: Encode` is not satisfied
--> /home/x/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/778e9d1/substrate/primitives/runtime/src/generic/header.rs:75:39
|
75 | impl<Number, Hash> traits::Header for Header<Number, Hash>
| ^^^^^^^^^^^^^^^^^^^^ the trait `Encode` is not implemented for `generic::header::Header<Number, Hash>`, which is required by `generic::header::Header<Number, Hash>: Codec`
|
= note: required for `generic::header::Header<Number, Hash>` to implement `Codec`
note: required by a bound in `traits::Header`
--> /home/x/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/778e9d1/substrate/primitives/runtime/src/traits.rs:1199:24
|
1198 | pub trait Header:
| ------ required by a bound in this trait
1199 | Clone + Send + Sync + Codec + Eq + MaybeSerialize + Debug + TypeInfo + 'static
| ^^^^^ required by this bound in `Header`
help: consider extending the `where` clause, but there might be an alternative better way to express this requirement
|
78 | Hash: HashT, generic::header::Header<Number, Hash>: Encode
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
error[E0277]: the trait bound `generic::header::Header<Number, Hash>: Encode` is not satisfied
--> /home/x/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/778e9d1/substrate/primitives/runtime/src/generic/header.rs:148:17
|
148 | Hash::hash_of(self)
| ------------- ^^^^ the trait `Encode` is not implemented for `generic::header::Header<Number, Hash>`
| |
| required by a bound introduced by this call
|
note: required by a bound in `traits::Hash::hash_of`
--> /home/x/.cargo/git/checkouts/polkadot-sdk-cff69157b985ed76/778e9d1/substrate/primitives/runtime/src/traits.rs:973:16
|
973 | fn hash_of<S: Encode>(s: &S) -> Self::Output {
| ^^^^^^ required by this bound in `Hash::hash_of`
help: consider extending the `where` clause, but there might be an alternative better way to express this requirement
|
143 | Hash: HashT, generic::header::Header<Number, Hash>: Encode
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Compiling js-sys v0.3.74
Compiling darling v0.20.10
For more information about this error, try `rustc --explain E0277`.
error: could not compile `sp-runtime` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
Same issue for me. |
It seems that this issue was caused by some dependencies being updated, as I haven't encountered this problem locally. |
Exactly, it was after I |
@kevin-valerio @semuelle Thank you very much for your feedback. After running |
|
It seems that there have been some major upgrades and updates to the Polkadot SDK recently. |
@kevin-valerio @semuelle I switched the polkadot-sdk branch to |
semuelle
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Thanks for the updates, @YanOctavian & @kevin-valerio. I am happy to report that everything is working now and your milestone is hereby accepted. Congrats! You can find my evaluation notes here.
|
🪙 Please fill out the invoice form in order to initiate the payment process. Thank you! |
@semuelle Good job! Thank you very much. I have submitted the invioce. |
10 tasks
|
@semuelle @kevin-valerio Just wanted to know if the M1 payment could be processed before the 25th. If so, we would be very happy. Wishing you a wonderful holiday! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#2335