-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Threshold Signature Implementation: Milestone 2 Delivery #1226
Conversation
…gnature_Implementation-Milestone_1.md
…_Signature_Implementation-milestone_1.md
…o Threshold_Signature-milestone_1.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the milestone submission, @Fiono11. I'm still waiting for review from @burdges. In the meantime, I am testing the tutorial and I get stuck at ./olaf_cli threshold-sign-round2 --participant 1
. Until then, output looks good, but this returns the error
# ./olaf-cli threshold-sign-round2 --participant 1
Error: CliError("Failed to parse threshold public key: Base 58 requirement is violated")
Any suggestions what I might be missing?
Sorry, I forgot to push some fixes. Can you try again, please? |
Sorry for the long wait, @Fiono11. I was out this week, but I will look into it asap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Very sorry for the delay. I missed that this was you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your milestone is hereby accepted, @Fiono11. You can find the evaluation notes here.
If you haven't yet, please submit your invoice(s) through our invoice form.
Also, please submit the article to [email protected]. They will help you with the publication.
🪙 Please fill out the invoice form in order to initiate the payment process. Thank you! |
We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊 |
@Fiono11, the invoices you submitted are denominated in EUR, although the contract is in USD. We can pay in EUR, but then the amounts don't fit. Could you resubmit both invoices? |
Done! |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#2250