Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threshold Signature Implementation: Milestone 2 Delivery #1226

Merged
merged 22 commits into from
Dec 16, 2024

Conversation

Fiono11
Copy link
Contributor

@Fiono11 Fiono11 commented Nov 17, 2024

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#2250

@semuelle semuelle requested a review from burdges December 2, 2024 09:48
@semuelle semuelle self-assigned this Dec 2, 2024
@semuelle semuelle changed the title Threshold Signature Implementation: Milestone 1 Delivery Threshold Signature Implementation: Milestone 2 Delivery Dec 6, 2024
Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the milestone submission, @Fiono11. I'm still waiting for review from @burdges. In the meantime, I am testing the tutorial and I get stuck at ./olaf_cli threshold-sign-round2 --participant 1. Until then, output looks good, but this returns the error

# ./olaf-cli threshold-sign-round2 --participant 1
Error: CliError("Failed to parse threshold public key: Base 58 requirement is violated")

Any suggestions what I might be missing?

@Fiono11
Copy link
Contributor Author

Fiono11 commented Dec 6, 2024

Thanks for the milestone submission, @Fiono11. I'm still waiting for review from @burdges. In the meantime, I am testing the tutorial and I get stuck at ./olaf_cli threshold-sign-round2 --participant 1. Until then, output looks good, but this returns the error

# ./olaf-cli threshold-sign-round2 --participant 1
Error: CliError("Failed to parse threshold public key: Base 58 requirement is violated")

Any suggestions what I might be missing?

Sorry, I forgot to push some fixes. Can you try again, please?

@Fiono11 Fiono11 requested a review from semuelle December 6, 2024 16:28
@semuelle
Copy link
Member

Sorry for the long wait, @Fiono11. I was out this week, but I will look into it asap.

Copy link

@burdges burdges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Very sorry for the delay. I missed that this was you.

Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your milestone is hereby accepted, @Fiono11. You can find the evaluation notes here.

If you haven't yet, please submit your invoice(s) through our invoice form.

Also, please submit the article to [email protected]. They will help you with the publication.

@semuelle semuelle merged commit 14e28b5 into w3f:master Dec 16, 2024
3 checks passed
Copy link

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

Copy link

We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊

So, where to from here? First of all, you should join our Grants Community chat, if you haven't already, so we can stay in touch.
If you are looking for continuative support for your project, there are quite a few options. The main goal of the W3F grants program is to support research as well as early-stage technical projects. If your project still falls under one of those categories, you might want to apply for a follow-up grant. However, depending on your goals and project status, there are other support programs in our ecosystem that might be better suited as the next step. For example, projects with a Business Case/Token should look into the Substrate Builders Program or VC Funding and Common Good projects have a good chance of receiving Treasury Funding. If you are looking for guidance, the team at https://substrate.io/ecosystem/square-one/ has compiled a list of ecosystem support sources and are happy to help you navigate it.

For a more comprehensive list, see our Alternative Funding page. Let us know if you have any questions regarding the above. We are more than happy to point you to additional resources and help you determine the best course of action.
Lastly, we hope your W3F grant was a success and we want to thank you for being part of the journey!

@semuelle
Copy link
Member

@Fiono11, the invoices you submitted are denominated in EUR, although the contract is in USD. We can pay in EUR, but then the amounts don't fit. Could you resubmit both invoices?

@Fiono11
Copy link
Contributor Author

Fiono11 commented Dec 19, 2024

@Fiono11, the invoices you submitted are denominated in EUR, although the contract is in USD. We can pay in EUR, but then the amounts don't fit. Could you resubmit both invoices?

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants