shivarthu-milestone-2

[amiyatulu]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• This pull request is being made by the same account as the accepted application.
• I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
• In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#525 < please fill this in with the PR number of your application.

[keeganquigley]

Thanks for the delivery @amiyatulu a couple of initial comments:

• The application states that React will be used for the front-end. Instead, the front-end delivered is in Leptos/Rust. Can you state the reasons for the change? As a change like this typically requires an amendment to be approved ahead of time.
• On the deployed Leptos app, when I select the "test net" button it doesn't do anything. Is this supposed to be working?
• There is a ton of template text still left in the readme from the Substrate Node Template. Can you please remove the text that doesn't apply for this project? Most of it can be removed since this template has been deprecated, leaving a lot of broken links.
• Some unit tests are failing, if you could look into fixing these. Thanks!

[amiyatulu]

I moved to leptos, because of rust compile time checking and rust safety. It will be easier to maintain and debug rust code in long run.

"test net" button doesn't do anything, currently substrate is not hosted, so its not testnet now.

I updated the code yesterday with some cleanup, so some tests are failing. Will update the tests and readme soon and get you back.

[amiyatulu]

Hi, updated the unit tests and cleaned up the readme.

[keeganquigley]

Hi @amiyatulu thanks for the fixes, much appreciated. The unit tests are all passing now. Moving on, there are a ton of cargo clippy warnings, can you take a look to see if any of these are easily fixable?

Additonally, when running cargo test --features runtime-benchmarks there are quite a few benchmarking tests failing. Can you please take a look at the evaluation and provide fixes when possible.

Since it's the last milestone, would be great if we could button these up as much as possible. Thanks!

[amiyatulu]

Hi @keeganquigley Thank you for your reply. Working on benchmarking, and will get back to you when done.

[keeganquigley]

Thanks @amiyatulu sounds good. Also, FYI I wrote the wrong command for benchmarks, the updated one is what I actually used cargo test --features runtime-benchmarks to test all at once.

[keeganquigley]

Hi @amiyatulu making any progress?

[amiyatulu]

@keeganquigley
Yes, I have updated benchmark of two pallets, more two pallets are left.

[keeganquigley]

Sounds good, no rush, just wanted to make sure progress was being made. Thanks!

[amiyatulu]

@keeganquigley Hi, please check out cargo test --features runtime-benchmarks Its successfully running now.

[keeganquigley]

Thanks for the fixes @amiyatulu looks great now. Here is my final evaluation. Happy to pass the milestone, good work!

[github-actions]

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

[amiyatulu]

Hi, may grant was approved before Feb 19, 2024 and don't contain DOT portion. The form asks Polkadot AssetHub address, but application form contain ethereum address. Should I give the ethereum address in Invoice?

[keeganquigley]

Hi @amiyatulu yes we stopped issuing ETH mainnet payments a while back. Would you be willing to accept USDC on AssetHub instead?

[amiyatulu]

@keeganquigley Hi, currently there are no good UI for asset swapping in AssetHub. I tried to teleport some DOT in kheopswap, it failed without any error messages, may be some bug in it. Is it possible to pay DAI in Eth mainnet this time? I asked in W3F Community Element Chat, they said its still valid.

[keeganquigley]

Thanks @amiyatulu yes that's fine, I just wanted to check if you'd be willing to switch since it is our new preferred method. But no worries, we should be able to stick with the original method and payment address. Feel free to include the DAI address on the form instead.

[amiyatulu]

@keeganquigley Thank you. Ya I already filled the form.

[amiyatulu]

Hi @keeganquigley Any updates when payment will be released.

[keeganquigley]

Hi @amiyatulu since it has been almost two weeks, I believe the payment should go out in this Friday's batch. Please let me know if you don't receive it after Friday. Thanks!

[amiyatulu]

@keeganquigley Hi, I have not recieved the payment last week. I was told to update the invoice as it was incomplete. I have re-submitted the invoice.

[amiyatulu]

Hi @keeganquigley, any updates regarding payment?

[keeganquigley]

Hi @amiyatulu just responded to your email :)

[RouvenP]

hi @amiyatulu we just sent the payment