TuxedoDapp milestone 2

[AltiMario]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• This pull request is being made by the same account as the accepted application.
• I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
• In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#2112

[PieWol]

Hey @AltiMario ,
I'm looking forward to finally review this delivery. Is there anything you would like to change or fix beforehand? Just checking in as there were quite some changes to the first delivery after this one was put up. Let me know if the testing guide is complete and working.

[AltiMario]

hi @PieWol thanks for your support. We managed to fix the frontend, however, a little tuning has to be done in the backend as well because the flag "not for selling" after a purchase doesn't reset. I believe it can be fixed this week and I will invite you for the (hopefully) final review asap.

[PieWol]

Perfect, thank you!

[PieWol]

Hey @AltiMario ,
any updates? :)

[AltiMario]

hi, @PieWol, I think @NadigerAmit is going to share some information about it

[NadigerAmit]

Hi @PieWol
cc: @AltiMario

I am sorry for the late reply.

The status of a kitty being "for sale" or not is determined by the blockchain logic. This information is stored as part of the transaction in the block, so the frontend does not control whether a kitty is for sale. The decision is based on whether the output kitty instance in the transaction is of type "Kitty piece" or "Tradable kitty piece."

Our original game design is as follows:

We categorized kitties into two types:
a. Kitty - These kitties are not for sale.
b. TradableKitty - These kitties are available for sale which as extra feild price.

When we want to sell a kitty, a "Kitty" is converted to a "TradableKitty" via the "List kitty for sale" process. Once a sale is completed, only the ownership of the kitty changes from the seller to the buyer, along with the transfer of funds. The type of the kitty remains "TradableKitty" even after the transaction.

If the new owner does not wish to sell the purchased kitty, they need to submit a separate transaction to convert the "TradableKitty piece" back to a regular "Kitty piece" using the delist_kitty_from_sale API.

Implementing a feature that automatically makes the purchased kitty "not for sale" would require changes to both the blockchain logic and the web service code. This would not be a straightforward modification and needs a significant effort.

Therefore, I recommend maintaining the current design and implementation at this point in time.

[PieWol]

Thank you @AltiMario and @NadigerAmit ,
I'll start my review tomorrow.

[PieWol]

Hey @AltiMario ,
where exactly is the testing guide for this milestone located?

[AltiMario]

Hi @PieWol,
In the README file, the section "Stage 2: Developing a basic CryptoKitties DApp" is related to the second milestone.
You can find it here.
At the bottom of the page, there's the section "Further documentation" that contains all the relevant documents of the project. The "testing guide" within this section is the document you should use to run the full stack and test "stage 2" (meaning milestone 2).
The document "Dapp specification" contains many technical details including the Kitty management (relevant for M2), but it is not a testing guide.
In the README, the other sections "Comparative analysis" and "Additional extra work and experiments" are not necessary for closing milestone 2 but provide additional insights into our project's depth and involvement.
I hope I answered your question.

[PieWol]

Hey @AltiMario and @NadigerAmit ,
I'm sad to hear that this change from a tradableKitty back to a kitty upon a sale isn't within the scope of your options for this grant. This issue will not hinder this milestone from acceptance though. Thanks for all of your time and efforts you put into this.

[github-actions]

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

[github-actions]

We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊

So, where to from here? First of all, you should join our Grants Community chat, if you haven't already, so we can stay in touch.
If you are looking for continuative support for your project, there are quite a few options. The main goal of the W3F grants program is to support research as well as early-stage technical projects. If your project still falls under one of those categories, you might want to apply for a follow-up grant. However, depending on your goals and project status, there are other support programs in our ecosystem that might be better suited as the next step. For example, projects with a Business Case/Token should look into the Substrate Builders Program or VC Funding and Common Good projects have a good chance of receiving Treasury Funding. If you are looking for guidance, the team at https://substrate.io/ecosystem/square-one/ has compiled a list of ecosystem support sources and are happy to help you navigate it.

For a more comprehensive list, see our Alternative Funding page. Let us know if you have any questions regarding the above. We are more than happy to point you to additional resources and help you determine the best course of action.
Lastly, we hope your W3F grant was a success and we want to thank you for being part of the journey!