-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TuxedoDapp milestone 1 #1170
TuxedoDapp milestone 1 #1170
Conversation
mandatory for the milestone approval
This reverts commit 1ddbce9.
Hey @AltiMario , I have put up my evaluation for you to carefully read. Looking forward to you getting back to me on this by putting up the amendment PR to your original application and providing me answers to all questions and concerns in this conversation or by introducing changes to your delivery. You can get more info about amendment PRs in the FAQ of the W3F Grants Program website. Please notify me once you think all points have been addressed and you deem your delivery ready for a re-evaluation. |
Related to the evaluation w3f#1175
hi @PieWol thanks for taking the time to review my project.
Thank you very much. |
Hey @NadigerAmit and @AltiMario , Which is the link to the document that I can use as the testing guide, which will walk me through all the necessary steps to run all pieces needed to evaluate the functionality of this milestone? I would think that I need to run the tuxedo chain and the dApp to then interact with the CLI-wallet or Talisman to submit my transactions. |
Hey @NadigerAmit and @AltiMario , |
@PieWol , Yes you need to run the Tuxedo blockchain so that Dapp and/Cli-wallet can interact with Tuxedo pieces for any transactions to execute. For CLI-wallet, you can refer to https://github.com/mlabs-haskell/Tuxedo/blob/main/wallet/README.md |
Thanks @NadigerAmit , what about the webservice? Have you seen my question about the webservice in the evaluation? I was wondering why you were creating the webservice and the dApp as different entities. So basically I would have expected the dApp to be the only entity between wallet and blockchain. I appreciate your help ^^ |
Hey @PieWol, I reply to your last question and let @NadigerAmit go into more detail if you still need it. There were some key aspects of Tuxedo that we weren't aware of at the beginning, which caused challenges and strong delays. 2- Missing functionalities: Tuxedo currently lacks support for smart contracts and external indexers. Without these features, we had to rely on a database to track and query UTXO transactions. Even if we could've built everything on the DApp's frontend, the use of a central database would've meant the application wasn't fully decentralized. To make progress, we ended up exposing the CLI wallet's functions as APIs that the frontend could interact with. While this doesn't result in a fully decentralized application, considering Tuxedo's limitations at the time, a purely decentralized approach wouldn't have been feasible anyway. |
@NadigerAmit please ping me as soon as you have answers to the questions from the evaluation. |
Hey @NadigerAmit , no worries about bothering me. I'm happy to get updates from you. Whenever you are uncertain about the evaluation please feel free to reach out. There was basically only one question remaining which wasn't answered by Mario. I was wondering which node version I should use for the dApp to work. Most importantly I would like you to view this part of the evaluation. It's not a question itself but an ask for you to deliver a testing guide.
|
hi @PieWol you are right, the documentation to run the dApp is fragmented and incomplete. I asked @philoniare to help me produce a new version that covers the gaps, but he is busy with other projects these days. It will take some days before you can read it, so please pause the evaluation for now and I will update you ASAP. Sorry for the inconvenience. |
hello @PieWol please look at the new Testing guide and let me know your thoughts. |
Hey @AltiMario , |
Hey @AltiMario , |
hi @PieWol, |
hello @PieWol , |
Hi @AltiMario , |
hi, @PieWol yes I also encountered this problem during my tests.
|
@AltiMario, for me the features were even more limited before running into the issue which rendered everything dysfunctional. I could list a kitty for sale via the dApp. Breeding etc. doesn't work and this is the logs that appear in the webservice when trying to breed as shown in the image above.
Even after restarting the dApp and using the chrome developer console to mitigate cache issues I was not successful. Are you planning to do anything about it? I recall you mentioning that your team already left so I assume it's hard to fix the dApp from this point on. In case you would construct me a dedicated testing guide to use the cli-wallet for all the chain and webservice interaction we could quickly have this first milestone 1 accepted and abort the second milestone which focusses on the dApp. I'm just throwing some possibilities around. Looking forward to what you think and want to do. I can also try again tomorrow in case you are convinced that it's just a rare hickup from the dApp. Best, |
oh no, it would be a shame to throw away all the work done on milestone 2 because of a bug in the navigation. |
Got it, thanks for stating your commitment! Will do so tomorrow. |
Hey @AltiMario , Kind regards, |
Hey @AltiMario , are there any updates you might be able to share with us? |
Hi @PieWol we fixed the front end but it needs a little more tuning before your review. I'll ping you in a few days. Thanks and sorry for the long wait. |
Hello @PieWol after my careful test (starting from scratch and following/updating the testing guide), I can finally ask you again to restart the review. |
Hey @AltiMario, thanks for the great changes. Now almost everything is working. There is only one issue with the frontend that shows already purchased Kitties still as "for sale" so that the UI supports transactions which will fail and the Kitty will not change ownership again. Are you aware of this? Do you have any idea why this is the case? |
Sorry, I just realized that the frontend is part of Milestone 2. This issue will not impact this evaluation. Your milestone is now accepted :) |
🪙 Please fill out the invoice form in order to initiate the payment process. Thank you! |
Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we've created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation's guidelines in doing so. If you haven't already, reach out to [email protected] for feedback on your announcement and cross-promotion. |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#2112