Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Futur Protocol #1165

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Futur Protocol #1165

merged 4 commits into from
Apr 16, 2024

Conversation

morgueye4
Copy link
Contributor

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#2168 < please fill this in with the PR number of your application.

@morgueye4 morgueye4 requested a review from semuelle April 7, 2024 14:04
@keeganquigley keeganquigley self-assigned this Apr 9, 2024
Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the delivery @morgueye4

  • the link in delivery "4. Futur Console" gives 404 error, can you fix this?
  • the "3. SAST/DAST module" deliverable links to the Mobsf, but I'm not sure what is supposed to be evaluated here. Am I supposed to be running something to coordinate with backend and off-chain workers?

Thanks for any further instructions you can provide!

@keeganquigley
Copy link
Contributor

Also are there any unit tests for the backend functions?

@morgueye4
Copy link
Contributor Author

morgueye4 commented Apr 14, 2024

Thank you @keeganquigley for the feedback.

the link in delivery "4. Futur Console" gives 404 error, can you fix this?

We omitted to turn the repository public it was private. Now it is accessible.

the "3. SAST/DAST module" deliverable links to the Mobsf, but I'm not sure what is supposed to be evaluated here. Am I supposed to be running something to coordinate with backend and off-chain workers?

Here the Deliverable is a deployed instance of MobSF in a server in a GCP instance with the proxy alongside with the MobSF instance.

You can run it locally by using Docker by following the instructions.

In the context of the FuturConsole, our instance is called by the Frontend Console futur-console-react to submit apks or to scan and retrieve results

Also are there any unit tests for the backend functions?

I have updated the readme and added a guide on how to test the functions with the Firebase emulator.

@morgueye4 morgueye4 requested a review from keeganquigley April 14, 2024 16:28
@keeganquigley
Copy link
Contributor

Thanks @morgueye4 for the heads up. Are there any other repos that are private? Please take note of our policy when it comes to open-sourcing.

@morgueye4
Copy link
Contributor Author

Thanks @morgueye4 for the heads up. Are there any other repos that are private? Please take note of our policy when it comes to open-sourcing.

Welcome @keeganquigley and thanks for sharing but no worries, there are no other private repos, this one was an omission about turning it public.

Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @morgueye4 I was able to get through everything and am now just in the last steps of setting up my developer account at https://console-relai.web.app/developer

It is asking me for some $RL to submit the tx. Is this the testnet token? Can you please send some to 5H1SgrToMp1RYhbUjzQmVxpRGRvo3s2j4xKUjCWJ9GQAVREM

Thanks! Also, I expected to get an insufficient balance error but instead it just hangs:

relai

@morgueye4
Copy link
Contributor Author

Thanks @morgueye4 I was able to get through everything and am now just in the last steps of setting up my developer account at https://console-relai.web.app/developer

It is asking me for some $RL to submit the tx. Is this the testnet token? Can you please send some to 5H1SgrToMp1RYhbUjzQmVxpRGRvo3s2j4xKUjCWJ9GQAVREM

Thanks! Also, I expected to get an insufficient balance error but instead it just hangs:

relai

Welcome @keeganquigley ! I just sent you some test tokens at the address you provided ! I have also updated the account creation guide for token requesting for new accounts.
We will have a look at the error handling for low balance and the like cases.

@morgueye4 morgueye4 requested a review from keeganquigley April 16, 2024 20:51
@keeganquigley
Copy link
Contributor

Awesome thanks @morgueye4 would be much appreciated. I was able to get it to work and am now willing to pass the milestone, here is my final evaluation. Congrats!

@keeganquigley keeganquigley merged commit 122936b into w3f:master Apr 16, 2024
3 checks passed
Copy link

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

Copy link

We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊

So, where to from here? First of all, you should join our Grants Community chat, if you haven't already, so we can stay in touch.
If you are looking for continuative support for your project, there are quite a few options. The main goal of the W3F grants program is to support research as well as early-stage technical projects. If your project still falls under one of those categories, you might want to apply for a follow-up grant. However, depending on your goals and project status, there are other support programs in our ecosystem that might be better suited as the next step. For example, projects with a Business Case/Token should look into the Substrate Builders Program or VC Funding and Common Good projects have a good chance of receiving Treasury Funding. If you are looking for guidance, the team at https://substrate.io/ecosystem/square-one/ has compiled a list of ecosystem support sources and are happy to help you navigate it.

For a more comprehensive list, see our Alternative Funding page. Let us know if you have any questions regarding the above. We are more than happy to point you to additional resources and help you determine the best course of action.
Lastly, we hope your W3F grant was a success and we want to thank you for being part of the journey!

@morgueye4
Copy link
Contributor Author

Awesome thanks @morgueye4 would be much appreciated. I was able to get it to work and am now willing to pass the milestone, here is my final evaluation. Congrats!

Thank you @keeganquigley and the team for giving a chance !

@RouvenP
Copy link

RouvenP commented Apr 22, 2024

hi @morgueye4 we sent the payment last Friday

@morgueye4
Copy link
Contributor Author

hi @morgueye4 we sent the payment last Friday

Hi @RouvenP, Indeed ! Thank you for letting me know !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants