Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ink!-playground m1 evaluation #1132

Merged
merged 6 commits into from
Feb 16, 2024
Merged

Ink!-playground m1 evaluation #1132

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
eb0c5dd
init ink playground file
PieWol Jan 30, 2024
c06cf6b
init layout
PieWol Jan 30, 2024
cb1efe3
add details
PieWol Feb 2, 2024
0e9ff31
update eval
PieWol Feb 12, 2024
5131f20
finalize eval
PieWol Feb 14, 2024
a62ebd4
Rename ink_playground_1_PieWol copy.md to ink_playground_1_PieWol.md
keeganquigley Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions evaluations/ink_playground_1_PieWol.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# Evaluation


- **Status:** accepted
- **Application Document:** https://github.com/w3f/Grants-Program/blob/master/applications/ink-playground-ide-improvements.md
- **Milestone:** 1
- **Previously successfully merged evaluation:** all by PieWol

**Milestone Number:** 1

**Context**
Implement Ink's Dependency versioning

**Deliverables**

| Number | Deliverable | Accepted | Link | Evaluation Notes |
| ------------- | ------------- | ------------- |------------- | ------------- |
| 0.a. | License | <ul><li>[x] </li></ul> | https://github.com/Zeeve-App/ink-playground/blob/version_play/LICENSE | Apache-2.0 |
| 0.b. | Documentation | <ul><li>[x] </li></ul> |https://github.com/Zeeve-App/ink-playground/blob/version_play/README.md | |
| 1. | On demand version specific compilation | <ul><li>[x] </li></ul> | https://github.com/paritytech/ink-playground/pull/815 | |
| 2. | Dependency Version support | <ul><li>[x] </li></ul> |https://github.com/paritytech/ink-playground/pull/815, https://github.com/paritytech/ink-playground/pull/817 | |
| 3. | Ink! Upgrades | <ul><li>[x] </li></ul> | https://github.com/paritytech/ink-playground/pull/815 | well done via github action |
| 4. | Select Ink! version from UI | <ul><li>[x] </li></ul> |https://github.com/paritytech/ink-playground/pull/817 | good and url versioning is included |

## General Notes

## Documentation
Default ink!-playground readme and your additional documentation included there makes a good documentation for this project. Thanks for the final update on this matter.

## Ink! version upgrade via Github-action
Grantee has shown that in his own non-archived repo the github actions are executed as expected.
https://github.com/Zeeve-App/ink-playground/actions/runs/7897895698

## Ink! version selection in playground + url
The selection of the versions works and is also displayed in the url as requested in the issues you completed.
Especially referencing issues https://github.com/paritytech/ink-playground/issues/460
and https://github.com/paritytech/ink-playground/issues/427

## Summary
After the documentation update and showcase of github action I see this as accepted.
Loading