add Solang_Playground-milestone_1

[salaheldinsoliman]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• This pull request is being made by the same account as the accepted application.
• I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
• In case of acceptance, an invoice must be submitted and the payment will be transferred to the Polkadot/fiat account provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: https://github.com/w3f/Grants-Program/pull/XXX < please fill this in with the PR number of your application.

[salaheldinsoliman]

@keeganquigley Here it is!

[keeganquigley]

Thanks for the delivery @salaheldinsoliman I'm noticing the default deliverables (0a. - 0d.) are missing. I understand Docker and Article may not be applicable for this milestone but could you still add a Documentation/Testing sections with links? Thanks!

[keeganquigley]

Please also see my evaluation; at the moment there are some unit tests failing.

[keeganquigley]

pinging @salaheldinsoliman

[salaheldinsoliman]

@keeganquigley I'm currently working on a full-on test suit, that covers most of the functionality of the language server. I am also cleaning up the repo a little bit (removing warnings and improving documentation)

[keeganquigley]

@salaheldinsoliman sounds good thanks for the update!

[salaheldinsoliman]

@keeganquigley Hello,
I added a test suite for the language server and cleaned up the repo. please check: https://github.com/hyperledger-labs/solang-playground/blob/main/crates/browser/tests/server_tests.rs

With that being said, I request a re-evaluation of the delivery.
Thanks!

[keeganquigley]

Thanks for the changes @salaheldinsoliman looks good and I'm willing to accept the milestone. You can find my evaluation here. Looking forward to seeing compiling in the browser! Thanks for adding the test suite.

[github-actions]

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we've created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation's guidelines in doing so. If you haven't already, reach out to [email protected] for feedback on your announcement and cross-promotion.

Thank you for your contribution, and good luck! If you have any remaining milestone, let us know if you encounter any delays by leaving a comment on the application PR or submitting an amendment.

[github-actions]

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

[salaheldinsoliman]

@keeganquigley Thanks!
I looked at the evaluation. FYI, this is the target repo now: https://github.com/hyperledger-labs/solang-playground
Please use that for future evaluations, I think there are no failing tests there

[semuelle]

@salaheldinsoliman, sorry for the delay. Your invoice should be processed on Monday latest.

[salaheldinsoliman]

That's okay, thanks for the update!

…

On Fri, Mar 8, 2024, 12:49 Sebastian Müller ***@***.***> wrote: @salaheldinsoliman <https://github.com/salaheldinsoliman>, sorry for the delay. Your invoice should be processed on Monday latest. — Reply to this email directly, view it on GitHub <#1126 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AL4ZHS37KFN2GLTIZG5VHCLYXGQTLAVCNFSM6AAAAABCYL3X6KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBVGU2TOMRTHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>