Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAuth 2 eval #1117

Merged
merged 7 commits into from
Feb 5, 2024
Merged

DAuth 2 eval #1117

merged 7 commits into from
Feb 5, 2024

Conversation

PieWol
Copy link
Member

@PieWol PieWol commented Jan 24, 2024

No description provided.

@PieWol PieWol mentioned this pull request Jan 26, 2024
5 tasks
@yyd106
Copy link
Contributor

yyd106 commented Jan 30, 2024

Hi, @PieWol
Few updates here:

  1. SDK license has been added;
  2. The inline documentation is in our code, as you can find them when you review our delivered repos;
  3. The SDK wallet has been integrated into Hexlink: https://www.hexlink.io/. They use DAuth as the email authentication;

@PieWol
Copy link
Member Author

PieWol commented Jan 30, 2024

Hey @yyd106 ,
thanks for adding the SDK license. I could also see that hexlink actually integrated your code even though it seems like an abandoned project since last year.

I could see some inline documentation but I would appreciate it if you could extend it slightly. E.g. the encrypt function is without any comments but seems to be a key component of your code. As soon as that's done I see all issues resolved. As this is the final milestone it would be a good opportunity to put in a final effort to simplify further development by others.

Thanks for your effort!

@yyd106
Copy link
Contributor

yyd106 commented Jan 31, 2024

Hi @PieWol , the inline comments have been added accordingly.

In addition, the Hexlink team is working on some new projects and has also promised to use DAuth/Openid3.

@PieWol
Copy link
Member Author

PieWol commented Feb 2, 2024

Hey @yyd106 ,
I can't seem to find the added inline docs, would you mind linking the updated version to me? Looks like the last commit to main was the addition of the license. Also thanks for updating me on the hexlink team. I'm glad to hear that they are still integrating with you. 🎉

@yyd106
Copy link
Contributor

yyd106 commented Feb 3, 2024

Hi @PieWol , The update is made on the grants branch. You can find the changes here: DAuth-Network/instant-proof@main...polka-grant

@PieWol
Copy link
Member Author

PieWol commented Feb 5, 2024

I see, thanks for linking it and putting in the final effort. I updated my evaluation. @yyd106

@semuelle semuelle merged commit 6c2f436 into w3f:master Feb 5, 2024
3 checks passed
Copy link

github-actions bot commented Feb 5, 2024

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants