QSTN - Deliverables

[qstnus]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• This pull request is being made by the same account as the accepted application.
• I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
• In case of acceptance, an invoice must be submitted and the payment will be transferred to the Polkadot/fiat account provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1082 < please fill this in with the PR number of your application.

[keeganquigley]

Thanks for the delivery @qstnus I have the following initial comments:

• The application in the above description says "XXX", could you replace this with your pull request number? Which is QSTN-Redefining-data-De-Fi-and-NFTs-on-Substrate.md Grants-Program#1082
• Can you please check off the rest of the boxes as well?
• Deliverables 4, 5, and 6 are missing from the delivery. Did you complete these and if so can you add them?
• The milestone tables you copied from the application don't contain any links. Can you please add a link to each section to show us what to evaluate? Here is an example.
• Also the Docker file that you linked to doesn't exist. I'm not finding it, could you please replace with the correct link?

[keeganquigley]

One pallet unit test is also failing if you could take a look:

test tests::create_new_survey_success ... ok
test tests::create_and_fund_survey_success ... ok
test tests::create_new_survey_fail_already_existing ... ok
test tests::fund_survey_fails_funding_inferior_participants_limit ... ok
test tests::fund_survey_fails_survey_not_created ... ok
test tests::fund_survey_fails_survey_already_funded ... ok
test tests::fund_survey_fails_survey_not_enough_balance ... ok
test tests::fund_survey_success ... ok
test tests::fund_survey_gives_expected_reward_amount_10000_for_1000 ... ok
test tests::fund_survey_fails_survey_not_owner ... ok
test tests::register_participant_fails_max_number_participants_reached ... ok
test tests::register_participant_fails_not_owner ... ok
test tests::register_participant_fails_participant_already_registered ... ok
test tests::register_participant_fails_survey_not_created ... ok
test tests::register_participant_fails_survey_is_not_active ... ok
test tests::register_participant_success ... ok
test tests::register_participant_fails_survey_not_funded ... ok
test tests::reward_participant_fails_already_rewarded ... FAILED
test tests::reward_participant_fails_participant_not_registered ... ok
test tests::reward_participant_fails_not_owner ... ok
test tests::reward_participant_fails_survey_not_created ... ok
test tests::reward_participant_fails_survey_not_funded ... ok
test tests::reward_participant_success ... ok

failures:

---- tests::reward_participant_fails_already_rewarded stdout ----
thread 'tests::reward_participant_fails_already_rewarded' panicked at pallets/survey/src/tests.rs:725:9:
Expected Ok(_). Got Err(
    Module(
        ModuleError {
            index: 2,
            error: [
                10,
                0,
                0,
                0,
            ],
            message: Some(
                "NotOwnerOfSurvey",
            ),
        },
    ),
)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    tests::reward_participant_fails_already_rewarded

test result: FAILED. 23 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.06s

error: test failed, to rerun pass `-p pallet-survey --lib`

[qstnus]

Hello @keeganquigley,

Thanks for this information. Below are answers to your questions. Looking forward to next steps!

1. I updated the description with our number which is 1082
2. I checked off the rest of the boxes
3. I added deliveries 4,5 and 6 to the document
4. I added a section for links to confirm each delivery
5. Docker file: https://github.com/QSTN-US/Polkadot-QSTN-v1/tree/main/qstn-substrate-node/substrate-node/docker

In regard to the error message. Our CTO realized there was a logic error where we had to:

• change line 726 - from "RuntimeOrigin::signed(participant_id)," to "RuntimeOrigin::signed(survey_owner),"

This change allows anyone with an account to withdraw as a survey participant. Previously, only the survey issuer could complete the survey. We fixed this issue and also included a screenshot to show it has been resolved:

• QSTN-US/Polkadot-QSTN-v1@f0e828d#diff-e6a7a4b1ff48a889e26281fa5d3fbbce93f7f2957ceed1d3fd8e0838358fe667

[qstnus]

Hello @keeganquigley,

Thanks for this information. Below are answers to your questions. Looking forward to next steps!

1. I updated the description with our number which is 1082
2. I checked off the rest of the boxes
3. I added deliveries 4,5 and 6 to the document
4. I added a section for links to confirm each delivery
5. Docker file: https://github.com/QSTN-US/Polkadot-QSTN-v1/tree/main/qstn-substrate-node/substrate-node/docker

In regard to the error message. Our CTO realized there was a logic error where we had to:

• change line 726 - from "RuntimeOrigin::signed(participant_id)," to "RuntimeOrigin::signed(survey_owner),"

This change allows anyone with an account to withdraw as a survey participant. Previously, only the survey issuer could complete the survey. We fixed this issue and also included a screenshot to show it has been resolved:

• QSTN-US/Polkadot-QSTN-v1@f0e828d#diff-e6a7a4b1ff48a889e26281fa5d3fbbce93f7f2957ceed1d3fd8e0838358fe667

[semuelle]

Thanks for the update, @qstnus. @keeganquigley is still out of office this week, so it'll probably take another week before you'll get some feedback. Sorry about that.

[qstnus]

Hello @semuelle,

Happy New Year! Thanks for the update and we look forward to hearing from you!

[keeganquigley]

Thanks for the changes @qstnus a couple of additional requests:

• The link to the license file is broken, and I'm not finding one in the repo. Can you add the license file back in?
• I'm not seeing any benchmarking tests for the pallet. Since this milestone would complete the grant, are you willing to either write them, or explain why benchmarking setup is not necessary? Thanks!

[keeganquigley]

Additionally, Docker also fails to build the node on both Ubuntu and Mac. Could you check to see what the issue might be?

Output

./build.sh
~/Polkadot-QSTN-v1/qstn-substrate-node/substrate-node/docker ~/Polkadot-QSTN-v1/qstn-substrate-node/substrate-node/docker
Building QSTN-US/qstn-substrate-node-v010:latest docker image, hang on!
[+] Building 73.3s (10/15)
 => [internal] load .dockerignore                                                                                    0.0s
 => => transferring context: 2B                                                                                      0.0s
 => [internal] load build definition from qstnsubstrate.Dockerfile                                                   0.0s
 => => transferring dockerfile: 1.79kB                                                                               0.0s
 => [internal] load metadata for docker.io/library/ubuntu:20.04                                                      1.3s
 => [internal] load metadata for docker.io/paritytech/ci-linux:production                                            1.2s
 => [builder 1/4] FROM docker.io/paritytech/ci-linux:production@sha256:dc9abf9e877c5bad94828245406dac8a186530e1ad6  56.4s
 => => resolve docker.io/paritytech/ci-linux:production@sha256:dc9abf9e877c5bad94828245406dac8a186530e1ad6a1b5f2072  0.0s
 => => sha256:9d21b12d5fab9ab82969054d72411ce627c209257df64b6057016c981e163c30 31.42MB / 31.42MB                     3.1s
 => => sha256:94ec252bb138516408d499a54bd40801d1c76e3e0182571a90bb138e86cce7e3 588.46MB / 588.46MB                  36.5s
 => => sha256:935ba62d5fdff39246cf9fca5697ae756bfdc34b2957c935254f447f1a296165 409.86MB / 409.86MB                  30.3s
 => => sha256:dc9abf9e877c5bad94828245406dac8a186530e1ad6a1b5f2072e5e19e1f64b4 762B / 762B                           0.0s
 => => sha256:2d60a4916bc3faa064d298c966fd315dd26cd42fd54ec492ec238a99f649ca50 10.01kB / 10.01kB                     0.0s
 => => extracting sha256:9d21b12d5fab9ab82969054d72411ce627c209257df64b6057016c981e163c30                            1.1s
 => => extracting sha256:94ec252bb138516408d499a54bd40801d1c76e3e0182571a90bb138e86cce7e3                           12.3s
 => => extracting sha256:935ba62d5fdff39246cf9fca5697ae756bfdc34b2957c935254f447f1a296165                            7.3s
 => [internal] load build context                                                                                    0.1s
 => => transferring context: 2.62MB                                                                                  0.0s
 => [stage-1 1/6] FROM docker.io/library/ubuntu:20.04@sha256:f2034e7195f61334e6caff6ecf2e965f92d11e888309065da85ff  10.1s
 => => resolve docker.io/library/ubuntu:20.04@sha256:f2034e7195f61334e6caff6ecf2e965f92d11e888309065da85ff50c617732  0.0s
 => => sha256:f2034e7195f61334e6caff6ecf2e965f92d11e888309065da85ff50c617732b8 1.13kB / 1.13kB                       0.0s
 => => sha256:080169816683e6f063d3903434565624287828ecfd06bd2f813b30325e8b1eca 424B / 424B                           0.0s
 => => sha256:fde9c12d7d3f936f56d545cc36391de434bbe311fd9d60f98e496c527cf58f21 2.32kB / 2.32kB                       0.0s
 => => sha256:d519a3a2a796a075e4e40e5c4a1513aa8db8f8fdf009662bf6858f0149143b28 25.97MB / 25.97MB                     9.3s
 => => extracting sha256:d519a3a2a796a075e4e40e5c4a1513aa8db8f8fdf009662bf6858f0149143b28                            0.7s
 => [builder 2/4] WORKDIR /substrate                                                                                 1.3s
 => [builder 3/4] COPY . /substrate                                                                                  0.0s
 => ERROR [builder 4/4] RUN cargo build --release                                                                   14.3s
------
 > [builder 4/4] RUN cargo build --release:
#6 0.383 info: syncing channel updates for 'nightly-x86_64-unknown-linux-gnu'
#6 0.929 info: latest update on 2024-01-10, rust version 1.77.0-nightly (190f4c961 2024-01-09)
#6 0.961 info: downloading component 'cargo'
#6 1.413 info: downloading component 'clippy'
#6 1.874 info: downloading component 'rust-analyzer'
#6 2.221 info: downloading component 'rust-src'
#6 2.387 info: downloading component 'rust-std' for 'wasm32-unknown-unknown'
#6 3.656 info: downloading component 'rust-std'
#6 5.074 info: downloading component 'rustc'
#6 8.589 info: downloading component 'rustc-dev'
#6 13.85 info: downloading component 'rustfmt'
#6 14.03 info: removing previous version of component 'rust-std' for 'wasm32-unknown-unknown'
#6 14.24 info: rolling back changes
#6 14.24 error: could not rename component file from '/usr/local/rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/wasm32-unknown-unknown/lib' to '/usr/local/rustup/tmp/m72rs11u31den_bz_dir/bk'
#6 14.24
#6 14.24 Caused by:
#6 14.24     Invalid cross-device link (os error 18)
------
process "/bin/sh -c cargo build --release" did not complete successfully: exit code: 1

Lastly, the polkadot.qstnus.com page also still displays "powered by Near". That makes sense for your regular landing page, but for the Polkadot version it would be nice if this could be changed :)

[qstnus]

Hello @keeganquigley,

Happy New Year and great to hear from you! Below are the answers to your questions. Looking forward to next steps!

1. We replaced the license file and added in this folder:
   https://github.com/QSTN-US/Polkadot-QSTN-v1/blob/main/LICENSE

2. We created benchmark testing which can be found here:
   https://github.com/QSTN-US/Polkadot-QSTN-v1/blob/main/qstn-substrate-pallet/survey/src/benchmarking.rs
   https://github.com/QSTN-US/Polkadot-QSTN-v1/blob/main/qstn-substrate-node/substrate-node/node/src/benchmarking.rs

3. The docker issue has been fixed with evidence below:
   https://github.com/QSTN-US/Polkadot-QSTN-v1/blob/main/qstn-substrate-node/substrate-node/Containerfile

• In regards to the Docker our CTO said the issue was "After you build the node with: "cargo build —release", build the docker contatiner using: "docker build -f Containerfile -t qstn-node."
• He said to clone this repository, go in the directory and run the commands: https://github.com/QSTN-US/Polkadot-QSTN-v1/tree/17102e4d8bd9403a694002ed1e40fe0bc6a0e499/qstn-substrate-node/substrate-node
• He said to build the node before you build the Docker because you will be unable to find the binary for the container

5. We changed the tagline to "Powered by Polkadot" with evidence below:

Dark mode -

Light mode -

[qstnus]

Hello @keeganquigley,

In addition, here is a demo video of the entire project: https://youtu.be/L5tZQTLslFo

[keeganquigley]

Thanks for the updates and for adding the benchmarking tests @qstnus looks good now! I'm happy to pass the milestone, here is my final evaluation. Congrats on completing the grant!

[github-actions]

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

[qstnus]

Hello @keeganquigley,

Thanks for the final review on our milestone. We look forward to continuing to build within the Polkadot ecosystem.

As a follow up, where should I email my invoice? I have read the documentation, here, and currently in the midst of completing the forms. Unfortunately, I need an email address to finish sending the invoice. Please advise.

[keeganquigley]

Hi @qstnus you don't have to email the invoice, but rather upload it on the Google Form. That way it can be approved and sent to our operations team. Alternatively, if you are having an issue, you can email it to [email protected] and we'll take care of it. Hope that helps!

[qstnus]

Hello @keeganquigley,

Thanks for this information. I sent the invoice following the outlined steps. Please let me know if you have any questions!

[RouvenP]

hi @qstnus we just sent the payment

[qstnus]

Hello @RouvenP,

The payment has been received. Thank you!