-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Profond-Milestone_2.md #1068
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @emarai, thanks for the delivery. I am looking through the deliverables and have a few questions.
- According to the grant application, the article should cover "the analytics and API usage", but it's mostly just showing screenshots and talking about selling tokens. It would be great if you could create a more technical article that explains and walks through what was done as part of the grant and how users can leverage it.
- I'm not familiar with Metabase at all. Could you add what is required to set up Metabase/postgres to the testing instructions to get the project to run locally?
- The frontend on profond.ai doesn't react to my wallet selection in Firefox.
- It also doesn't respect my network decision. It always creates a transaction for Shibuya.
- What is the data displayed in the analytics tab? I expected some real, live data there.
Hey @semuelle thanks for the review, we will provide the article, docs, and fix the bugs that you mentioned |
Any news here, @emarai? |
hi @semuelle , we're still working on it. Some update are already done in local. |
Hey @semuelle , we got an update for you!
lemme know if you have questions |
| ------ | ------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ----- | | ||
| 0a. | License | https://github.com/profondHQ/profond-analytics/blob/main/LICENSE | | ||
| 0b. | Documentation | User document at: https://profond.gitbook.io/docs/ . API documentation is on the backend API swagger: https://github.com/profondHQ/profond-backend-api | | | ||
| 0c. | Testing and Testing Guide | PSP22 Tests: https://github.com/profondHQ/profond-psp22-contract/tree/master/tests . API Tests: https://github.com/profondHQ/profond-backend-api/tree/master/test. | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 0c. | Testing and Testing Guide | PSP22 Tests: https://github.com/profondHQ/profond-psp22-contract/tree/master/tests . API Tests: https://github.com/profondHQ/profond-backend-api/tree/master/test. | | | |
| 0c. | Testing and Testing Guide | PSP22 Tests: https://github.com/profondHQ/profond-psp22-contract/tree/master/tests . API Tests: https://github.com/profondHQ/profond-backend-api/tree/master/test | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, @emarai. I can confirm that the article is in good shape now. However, I still have some issues, please have a look.
- The contract doesn't compile:
> yarn compile:release
yarn run v1.22.19
$ typechain-compiler --toolchain nightly-2023-03-13 --release
======== Found contracts ======== 10:38:30
base_token 10:38:30
======== Compiling base_token ======== 10:38:30
error: failed to parse manifest at `/tmp/cargo-contract_EQMJNY/contracts/base_token/Cargo.toml`
Caused by:
the target `base_token` is a binary and can't have any crate-types set (currentlERROR: command ["/home/profond/.rustup/toolchains/nightly-2023-03-13-x86_64-unknown-linux-gnu/bin/cargo", "build", "--color=always", "--target=wasm32-unknown-unknown", "-Zbuild-std=core,alloc", "--no-default-features", "--release", "--target-dir=/home/profond/profond-psp22-contract/target/ink/base_token", "-Zbuild-std-features=panic_immediate_abort"] exited with code 101
ERROR ======== Failed to compile base_token ======== 10:38:31
- Some of the tests fail:
> yarn run test
yarn run v1.22.19
$ jest
PASS src/app.controller.spec.ts (5.719 s)
FAIL src/stats/stats.service.spec.ts
● Test suite failed to run
Cannot find module 'src/constants' from 'stats/stats.service.ts'
Require stack:
stats/stats.service.ts
stats/stats.service.spec.ts
1 | import { Inject, Injectable } from "@nestjs/common";
> 2 | import { PG_CONNECTION } from "src/constants";
| ^
3 |
4 | @Injectable()
5 | export class StatsService {
at Resolver._throwModNotFoundError (../node_modules/jest-resolve/build/resolver.js:427:11)
at Object.<anonymous> (stats/stats.service.ts:2:1)
at Object.<anonymous> (stats/stats.service.spec.ts:2:1)
FAIL src/stats/stats.controller.spec.ts
● Test suite failed to run
Cannot find module 'src/constants' from 'stats/stats.service.ts'
Require stack:
stats/stats.service.ts
stats/stats.controller.ts
stats/stats.controller.spec.ts
1 | import { Inject, Injectable } from "@nestjs/common";
> 2 | import { PG_CONNECTION } from "src/constants";
| ^
3 |
4 | @Injectable()
5 | export class StatsService {
at Resolver._throwModNotFoundError (../node_modules/jest-resolve/build/resolver.js:427:11)
at Object.<anonymous> (stats/stats.service.ts:2:1)
at Object.<anonymous> (stats/stats.controller.ts:2:1)
at Object.<anonymous> (stats/stats.controller.spec.ts:2:1)
PASS src/coin/coin.service.spec.ts (7.806 s)
PASS src/collection/collection.service.spec.ts (7.812 s)
A worker process has failed to exit gracefully and has been force exited. This is likely caused by tests leaking due to improper teardown. Try running with --detectOpenHandles to find leaks. Active timers can also cause this, ensure that .unref() was called on them.
Test Suites: 2 failed, 3 passed, 5 total
Tests: 5 passed, 5 total
Snapshots: 0 total
Time: 8.684 s
> yarn run test:e2e
yarn run v1.22.19
$ jest --config ./test/jest-e2e.json
FAIL test/app.e2e-spec.ts
● Test suite failed to run
Cannot find module 'src/constants' from '../src/stats/stats.service.ts'
Require stack:
/home/profond/profond-backend-api/src/stats/stats.service.ts
/home/profond/profond-backend-api/src/stats/stats.module.ts
/home/profond/profond-backend-api/src/app.module.ts
app.e2e-spec.ts
1 | import { Inject, Injectable } from "@nestjs/common";
> 2 | import { PG_CONNECTION } from "src/constants";
| ^
3 |
4 | @Injectable()
5 | export class StatsService {
at Resolver._throwModNotFoundError (../node_modules/jest-resolve/build/resolver.js:427:11)
at Object.<anonymous> (../src/stats/stats.service.ts:2:1)
at Object.<anonymous> (../src/stats/stats.module.ts:2:1)
at Object.<anonymous> (../src/app.module.ts:8:1)
at Object.<anonymous> (app.e2e-spec.ts:4:1)
Test Suites: 1 failed, 1 total
Tests: 0 total
Snapshots: 0 total
Time: 3.012 s
Ran all test suites.
Also, some minor UI issues:
- It's still not clear to me what data is shown in the analytics tab. It shows the same whether I'm logged in or not. Does this refer to tokens deployed through Profond? If so, perhaps you can make this a bit more clear.
- All the entries in the analytics table look clickable, but aren't. Even the
buy
text. - After creating a token, it doesn't show up in my profile or in the dropdown on the launch page.
Noted, checking in! |
Hi @semuelle , we have updates for you:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, @ekkirinaldi . I can confirm that the tests are now working and that the indexer picked up my new token. Your milestone is hereby accepted. You can find my evaluation notes here.
Beyond the requirements of the grant agreement, I noticed a few things that I felt worth pointing out:
- the sale transactions currently fail with a generic error message in the console:
Object { dryResult: Map(5), errorMessage: "Error" }
- The analytics view didn't seem to pick up my token deployment transaction
- It seems that still only Shibuya network is supported at this point
- The e2e tests seem to only test for a 200 response from the backend; I would have expected more thorough tests.
In any case, congratulations on finishing the grant. Best of luck with the project going forward!
We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊 |
🪙 Please fill out the invoice form in order to initiate the payment process. Thank you! |
Hi @semuelle appreciate the feedback. We will look into list you're pointing at and will get back to you. In the meanwhile, we will proceed with the submission. Thank you for guiding us until this stage. |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#1682