Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plutonication milestone 1 #1056

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

RostislavLitovkin
Copy link
Contributor

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, an invoice must be submitted and the payment will be transferred to the Polkadot/fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1947

@keeganquigley keeganquigley self-assigned this Nov 21, 2023
@keeganquigley
Copy link
Contributor

Thanks for the delivery @RostislavLitovkin and sorry for the delay, I'm looking at this now.

@keeganquigley
Copy link
Contributor

keeganquigley commented Nov 29, 2023

Thanks again for your patience @RostislavLitovkin as we are a bit backlogged at the moment. Everything is looking good, except for two Playwright tests are failing. Can you look into these? Thanks!

playwright

I have the server running:

gunicorn -w 1 --threads 100 main:app
[2023-11-28 19:01:14 -0500] [19434] [INFO] Starting gunicorn 20.1.0
[2023-11-28 19:01:14 -0500] [19434] [INFO] Listening at: http://127.0.0.1:8000 (19434)
[2023-11-28 19:01:14 -0500] [19434] [INFO] Using worker: gthread
[2023-11-28 19:01:14 -0500] [19435] [INFO] Booting worker with pid: 19435

@keeganquigley
Copy link
Contributor

UPDATE: That was on Brave browser, I tried again on Chrome but the tests seem to time out.

Output
npx playwright test

Running 8 tests using 1 worker
[chromium] › events.spec.js:77:7 › events › create_room and pubkey
dApp connected
Wallet connected
  1) [chromium] › events.spec.js:77:7 › events › create_room and pubkey ────────────────────────────

    Test timeout of 30000ms exceeded.

[chromium] › events.spec.js:93:7 › events › sign_payload
dApp connected
Wallet connected
  2) [chromium] › events.spec.js:93:7 › events › sign_payload ──────────────────────────────────────

    Test timeout of 30000ms exceeded.

[chromium] › events.spec.js:120:7 › events › payload_signature
dApp connected
Wallet connected
  3) [chromium] › events.spec.js:120:7 › events › payload_signature ────────────────────────────────

    Test timeout of 30000ms exceeded.

[chromium] › events.spec.js:137:7 › events › payload_signature_rejected
dApp connected
Wallet connected
  4) [chromium] › events.spec.js:137:7 › events › payload_signature_rejected ───────────────────────

    Test timeout of 30000ms exceeded.

[chromium] › events.spec.js:152:7 › events › sign_raw
dApp connected
Wallet connected
  5) [chromium] › events.spec.js:152:7 › events › sign_raw ─────────────────────────────────────────

    Test timeout of 30000ms exceeded.

[chromium] › events.spec.js:170:7 › events › raw_signature
dApp connected
Wallet connected
  6) [chromium] › events.spec.js:170:7 › events › raw_signature ────────────────────────────────────

    Test timeout of 30000ms exceeded.

[chromium] › events.spec.js:187:7 › events › raw_signature_rejected
dApp connected
Wallet connected
  7) [chromium] › events.spec.js:187:7 › events › raw_signature_rejected ───────────────────────────

    Test timeout of 30000ms exceeded.

[chromium] › stresstest.spec.js:6:7 › stress tests › limit_socketio
Connected
pong: 0
pong: 1
pong: 2
pong: 3
pong: 4
pong: 5
pong: 6
pong: 7
pong: 8
pong: 9
pong: 10
pong: 11
pong: 12
pong: 13
pong: 14
pong: 15
pong: 16
pong: 17
pong: 18
pong: 19
pong: 20
pong: 21
pong: 22
pong: 23
pong: 24
pong: 25
pong: 26
  7 failed
    [chromium] › events.spec.js:77:7 › events › create_room and pubkey ─────────────────────────────
    [chromium] › events.spec.js:93:7 › events › sign_payload ───────────────────────────────────────
    [chromium] › events.spec.js:120:7 › events › payload_signature ─────────────────────────────────
    [chromium] › events.spec.js:137:7 › events › payload_signature_rejected ────────────────────────
    [chromium] › events.spec.js:152:7 › events › sign_raw ──────────────────────────────────────────
    [chromium] › events.spec.js:170:7 › events › raw_signature ─────────────────────────────────────
    [chromium] › events.spec.js:187:7 › events › raw_signature_rejected ────────────────────────────
  1 passed (3.7m)

@RostislavLitovkin
Copy link
Contributor Author

I have left a comment on your element @keeganquigley

@keeganquigley
Copy link
Contributor

Thanks @RostislavLitovkin I left additional comments as well.

@keeganquigley
Copy link
Contributor

Thanks for your help @RostislavLitovkin I was able to get everything to run. Here is my final evaluation. I'm happy to pass the milestone, and looking forward to the next one.

@keeganquigley keeganquigley merged commit 7d6626f into w3f:master Dec 5, 2023
6 checks passed
Copy link

github-actions bot commented Dec 5, 2023

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we've created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation's guidelines in doing so. If you haven't already, reach out to [email protected] for feedback on your announcement and cross-promotion.

Thank you for your contribution, and good luck! If you have any remaining milestone, let us know if you encounter any delays by leaving a comment on the application PR or submitting an amendment.

Copy link

github-actions bot commented Dec 5, 2023

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants