Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wasm-opt-for-rust-maintenance-11 #1046

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

brson
Copy link
Contributor

@brson brson commented Nov 2, 2023

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, an invoice must be submitted and the payment will be transferred to the BTC/ETH/fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1305


This month we fixed last month's link-time regression related to DWARF passes by adding an optional "dwarf" crate feature. This is still not optimal: projects that are linking to both the wasm-opt crate and the LLVM source code cannot get DWARF passes in binaryen because of duplicate symbols. At this time I do not have a better fix planned.

This project continues to have problems with long build times, and an issue has been filed suggesting another fix: to download pre-built binaryen archives for common platforms. I have not looked at the issue yet, but it is a potentially viable solution, probably not doable within the remaining time of this contract.


November will be the final month of this contract. I would like to discuss with somebody whether we should do this maintenance contract again next year (there are pros and cons); or even whether there are other infrastructural projects the w3f needs help with.

The long-awaited bug fix for unicode on windows - the one big bug I promised to fix in this contract - is fixed upstream but has not made it into a binaryen release yet. Presumably it will be in the next release and I will commit to getting that release into the wasm-opt crate even if the contract expires and is not renewed.

@semuelle semuelle self-assigned this Nov 6, 2023
Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @brson. Thanks for the delivery. I am happy to report that it is already accepted. You can find the evaluation notes here.

As for a new agreement, I am going to check internally.

@semuelle semuelle merged commit dd389c9 into w3f:master Nov 6, 2023
6 checks passed
Copy link

github-actions bot commented Nov 6, 2023

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants