Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treasury Tracker - Milestone 1 #1026

Merged
merged 7 commits into from
Oct 19, 2023
Merged

Treasury Tracker - Milestone 1 #1026

merged 7 commits into from
Oct 19, 2023

Conversation

senseless
Copy link
Contributor

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, an invoice must be submitted and the payment will be transferred to the BTC/ETH/fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1900

@senseless
Copy link
Contributor Author

senseless commented Oct 9, 2023

Can you please provide insight into "Check Author" automated check? I'm not sure where I went wrong on this check. I'd like to correct it if possible. Thank you.

Edit: Nevermind, Figured it out!

@senseless senseless changed the title Treasury Tracker - Milestone 1 Delivery Treasury Tracker - Milestone 1 Oct 10, 2023
@keeganquigley keeganquigley self-assigned this Oct 10, 2023
@keeganquigley
Copy link
Contributor

Thanks for the delivery @senseless glad you were able to figure it out. You can find my initial eval here. Please have a look as there are currently some tests failing. Thanks!

@senseless
Copy link
Contributor Author

Thanks for the delivery @senseless glad you were able to figure it out. You can find my initial eval here. Please have a look as there are currently some tests failing. Thanks!

The speed of the build, that can't be helped unfortunately. It's doing both a npm install and a composer install. The only thing to speed up that process is additional cpu and network speed. In a production environment, this would be using apache, mysql and the polkadotjs-proxy on separate nodes communicating over lan. There is also a 10 second delay on startup to give time for mysql to load properly so the apache docker can bootstrap the SQL.

Regarding the unit tests, I have made a new commit which should resolve the unit test issues. It appears some code from another repo was lost inadvertently. I had to make some new tests.

Regarding the UI bug that was highlighted, The referenda page should have been responsive already, but the banner may have caused an issue. The analytics page had a fixed width but is now responsive. We've pushed these changes to the live site. I recommend doing a force refresh in the browser to clear any caches. We do plan to improve UI significantly in the next set of updates bringing in the responsive elements and taking another step toward production quality.

Please let me know if you have further issues with the updated master branch

@keeganquigley
Copy link
Contributor

Thanks for the fixes @senseless no more failures, but still getting some error notices. I'm not super familiar with PHP, are these normal at this stage?

@senseless
Copy link
Contributor Author

senseless commented Oct 12, 2023

Thanks for the fixes @senseless no more failures, but still getting some error notices. I'm not super familiar with PHP, are these normal at this stage?

Based on those errors it appears as if you're running the unit tests outside of the docker environment. It's failing due to not being able to connect to the database running inside the other container (the host has no knowledge of the docker hostname schema). Based on the current configuration of the repo (designed for instant docker deployment) you will need to operate the phpunit command inside of the docker container. I will issue a commit shortly to update the documentation to reflect this.

Execute the following commands:

  • Gain access to a bash prompt on the web docker container docker exec -it treasury-tracker_web_1 /bin/bash
  • Execute the phpunit test from the "/var/www/treasurytracker" directory ./vendor/bin/phpunit -v tests

It's not really normal in most cases to build unit tests for php projects. This is honestly the first time I've done it. I can see use cases for more complex logic, but not at this stage.

@keeganquigley
Copy link
Contributor

Thanks @senseless I appreciate it; let me know when I should take another look.

@senseless
Copy link
Contributor Author

Thanks @senseless I appreciate it; let me know when I should take another look.

It should be good now

@keeganquigley
Copy link
Contributor

Thanks @senseless and apologies for the delay, I was OOO for a week. Here is my final eval. Please note the small UI glitch that I found. I am still happy to go ahead and accept the milestone. Thanks for your hard work!

@keeganquigley keeganquigley merged commit 3dd0960 into w3f:master Oct 19, 2023
3 checks passed
@github-actions
Copy link

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

@github-actions
Copy link

We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊

So, where to from here? First of all, you should join our Grants Community chat, if you haven't already, so we can stay in touch.
If you are looking for continuative support for your project, there are quite a few options. The main goal of the W3F grants program is to support research as well as early-stage technical projects. If your project still falls under one of those categories, you might want to apply for a follow-up grant. However, depending on your goals and project status, there are other support programs in our ecosystem that might be better suited as the next step. For example, projects with a Business Case/Token should look into the Substrate Builders Program or VC Funding and Common Good projects have a good chance of receiving Treasury Funding. If you are looking for guidance, the team at https://substrate.io/ecosystem/square-one/ has compiled a list of ecosystem support sources and are happy to help you navigate it.

For a more comprehensive list, see our Alternative Funding page. Let us know if you have any questions regarding the above. We are more than happy to point you to additional resources and help you determine the best course of action.
Lastly, we hope your W3F grant was a success and we want to thank you for being part of the journey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants