Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Melodot milestone 2 #1022

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Melodot milestone 2 #1022

merged 1 commit into from
Oct 11, 2023

Conversation

DarkingLee
Copy link
Contributor

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, an invoice must be submitted and the payment will be transferred to the BTC/ETH/fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1804

@keeganquigley keeganquigley self-assigned this Oct 5, 2023
@keeganquigley
Copy link
Contributor

Thanks for the delivery @DarkingLee and sorry for the delay. Here is my initial evaluation. The Docker script is failing on two operating systems for me, wondering if you can look into it. Thanks!

@DarkingLee
Copy link
Contributor Author

Hello @keeganquigley, thank you for your detailed evaluation. I have essentially addressed the issues you mentioned in the evaluation.

  1. Docker has been fixed and now runs smoothly on both macOS and Ubuntu.
  2. macOS can now compile, but unfortunately, it encounters an upstream issue paritytech/substrate/#13804 It hasn't actually been resolved: paritytech/polkadot-sdk/#1755 I've tried mixing several different versions, but none of them work. I believe it's not feasible to fix this within this milestone as trying numerous version combinations would require extensive compilation time. We'll tackle this in the next milestone (either find the right version or implement another fix), so I don't have to wait for compilations.
  3. The missing protoc crate issue has been added to the setup.

@keeganquigley
Copy link
Contributor

Thanks for the fixes @DarkingLee everything works now and I am happy to pass the milestone. I have updated the evaluation accordingly. Thanks for the great work!

@keeganquigley keeganquigley merged commit 892c1ac into w3f:master Oct 11, 2023
6 checks passed
@github-actions
Copy link

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants