Skip to content

Commit

Permalink
Ink playground m2 (#1189)
Browse files Browse the repository at this point in the history
* accept ink-playground m2

* fix deliverable links
  • Loading branch information
PieWol authored Jun 13, 2024
1 parent 96a7740 commit d16dc56
Showing 1 changed file with 26 additions and 0 deletions.
26 changes: 26 additions & 0 deletions evaluations/ink_playground_2_PieWol.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
# Evaluation


- **Status:** accepted
- **Application Document:** https://github.com/w3f/Grants-Program/blob/master/applications/ink-playground-ide-improvements.md
- **Milestone:** 2
- **Previously successfully merged evaluation:** all by PieWol

**Milestone Number:** 2

**Context**
Implement playground features for ink crate docs.

**Deliverables**

| Number | Deliverable | Accepted | Link | Evaluation Notes |
| ------------- | ------------- | ------------- |------------- | ------------- |
| 0.a. | License | <ul><li>[x] </li></ul> | https://github.com/Zeeve-App/ink-playground/blob/version_play/LICENSE | Apache-2.0 |
| 0.b. | Documentation | <ul><li>[x] </li></ul> |https://github.com/Zeeve-App/ink-playground/blob/version_play/README.md | |
| 1. | Ink! crate docs | <ul><li>[x] </li></ul> | [use-ink/ink-playground#817](https://github.com/use-ink/ink-playground/pull/817), https://github.com/paritytech/ink-playground/blob/f2f44735310b4f966ade842125bc56eaaf915c95/packages/playground/src/app/index.tsx, https://github.com/Zeeve-App/ink-playground/commit/5bb6b61e067ea1b9ce17d099d994993e891437c1, https://github.com/Zeeve-App/ink/commit/0a4f21e89e2515db37b664632d7e3d0c4d1ec54f| only for one example but correctly implemented. |


## General Notes
Thanks for the implementation. I would love to see these changes making their way into the official ink repo once it will be picked up by new ecosystem players.

I couldn't test for various reasons but given the circumstances I will accept this delivery.

0 comments on commit d16dc56

Please sign in to comment.