Skip to content

Commit

Permalink
Merge pull request #1149 from PieWol/create-substrate-app-1-piewol
Browse files Browse the repository at this point in the history
create-substrate-app m1 eval
  • Loading branch information
keeganquigley authored Mar 13, 2024
2 parents 194ba58 + d59155d commit 84f6520
Showing 1 changed file with 30 additions and 0 deletions.
30 changes: 30 additions & 0 deletions evaluations/create-substrate-app-1-piewol.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# Evaluation


- **Status:** accepted
- **Application Document:** https://github.com/w3f/Grants-Program/blob/master/applications/create-substrate-app.md
- **Milestone:** 1
- **Previously successfully merged evaluation:** All evaluations by PieWol


**Milestone 1**

| Number | Deliverable | Accepted |Link | Evaluation Notes |
|--------:|---------------------------------------| :------: |-----------------------------------------------------------------------------------------------------------------------------------------------------------------|------------|
| **0a.** | License | <ul><li>[x] </li></ul> |https://www.apache.org/licenses/LICENSE-2.0| |
| **0b.** | Documentation | <ul><li>[x] </li></ul> |https://www.create-substrate-app.dev/| nice layout and concise docs |
| **0c.** | Testing and Testing Guide | <ul><li>[x] </li></ul> |https://www.create-substrate-app.dev/docs/available-scripts | works |
| 0e. | Article | <ul><li>[x] </li></ul> |https://www.philoniare.com/blog/create-substrate-app| good |
| 1. | TypeScript React Front-End Template | <ul><li>[x] </li></ul> |https://github.com/philoniare/create-substrate-app/tree/master/packages/react| works |
| 2. | TypeScript Vue Front-End Template | <ul><li>[x] </li></ul> |https://github.com/philoniare/create-substrate-app/tree/master/packages/vue| works|
| 3. | TypeScript Angular Front-End Template | <ul><li>[x] </li></ul> |https://github.com/philoniare/create-substrate-app/tree/master/packages/angular| works |
| 4. | Published Global CLI command | <ul><li>[x] </li></ul> |https://www.npmjs.com/package/create-substrate-app| good |



## General Notes
Thank you for the quick changes, the milestone looks good to me now. All tests are passing. I see this as accepted.

I appreciate that all suggestion were quickly picked up and delivered.


0 comments on commit 84f6520

Please sign in to comment.