Update DAOsign_m2_keeganquigley.md

w3f · Nov 5, 2024 · 7f6b1da · 7f6b1da
1 parent bd7bc75
commit 7f6b1da
Showing 1 changed file with 11 additions and 7 deletions.
diff --git a/evaluations/DAOsign_m2_keeganquigley.md b/evaluations/DAOsign_m2_keeganquigley.md
@@ -1,23 +1,27 @@
 # Evaluation
 
 
-- **Status:** in progress
+- **Status:** Accepted
 - **Application Document:** https://github.com/w3f/Grants-Program/blob/master/applications/DAOsign.md
 - **Milestone:** 2
 - **Previously successfully merged evaluation:** PieWol
 
 | Number | Deliverable | Accepted | Link | Notes |
 | ------------- | ------------- | ------------- | ------------- | ------------- |
 | 0a. | License | <ul><li>[x] </li></ul> | [LICENSE](https://github.com/DAOsign/daosign-ink-js-sdk/blob/main/LICENSE) | Apache 2.0 |
-| 0b. | Documentation                   | <ul><li>[x] </li></ul> | [Readme](https://github.com/DAOsign/daosign-ink-js-sdk/blob/main/README.md) |  |
-| 0c.    | Testing and Testing Guide | <ul><li>[x] </li></ul> |         https://github.com/DAOsign/daosign-ink-js-sdk?tab=readme-ov-file#testing                                                                                                               |         |
-| 0d.    | Docker                    | <ul><li>[x] </li></ul> |   https://github.com/DAOsign/polkadot-smart-contracts?tab=readme-ov-file#with-docker                                                                                                                     | 
-| 1. | DAOsign Ink! JS SDK             | <ul><li>[x] </li></ul> | [Github Repo](https://github.com/DAOsign/daosign-ink-js-sdk), [npm package](https://www.npmjs.com/package/@daosign/polkadot)      | |
-| 2. | DAOsign Application Integration | <ul><li>[x] </li></ul> |      [Github Repo](https://github.com/DAOsign/frontend) | 
+| 0b. | Documentation                   | <ul><li>[x] </li></ul> | [Readme](https://github.com/DAOsign/daosign-ink-js-sdk/blob/main/README.md) | Readme could be updated. |
+| 0c.    | Testing and Testing Guide | <ul><li>[x] </li></ul> |         https://github.com/DAOsign/daosign-ink-js-sdk?tab=readme-ov-file#testing                                                                                                               | All passing.        | 
+| 0d.    | Docker                    | <ul><li>[x] </li></ul> |   https://github.com/DAOsign/polkadot-smart-contracts?tab=readme-ov-file#with-docker                                                                                                                     | Ok.
+| 1. | DAOsign Ink! JS SDK             | <ul><li>[x] </li></ul> | [Github Repo](https://github.com/DAOsign/daosign-ink-js-sdk), [npm package](https://www.npmjs.com/package/@daosign/polkadot)      | Ok. |
+| 2. | DAOsign Application Integration | <ul><li>[x] </li></ul> |      [Github Repo](https://github.com/DAOsign/frontend) | Ok.
 
 # General Notes
 
-All unit tests now passing with good coverage:
+Passed but for the next milestone consider writing some better docs. 
+
+~~Only two unit tests.~~
+
+UPDATE: All unit tests now passing with good coverage:
 
 ```ts
  PASS  __tests__/DaosignPolkadotContractInteractor.test.ts (6.888 s)