Update xcNFT_2_keeganquigley.md

evaluations/xcNFT_2_keeganquigley.md

@@ -1,22 +1,22 @@
 # Evaluation
 
-- **Status:** In progress
+- **Status:** Accepted
 - **Application Document:** https://github.com/w3f/Grants-Program/blob/master/applications/xcNFT.md
 - **Milestone:** 2
 
 **Deliverables**
 | Number | Deliverable | Accepted | Link | Notes |
 | ------------- | ------------- | ------------- | ------------- | ------------- |
 | 0a. | License | <ul><li>[x] </li></ul> |[MIT xcNFT](https://github.com/paraspell-research/xcnft-pallet/blob/main/LICENSE), [MIT DOCS](https://github.com/paraspell-research/xcnft-docs/blob/main/LICENSE)| MIT| 
-| 0b.  | Documentation | <ul><li>[x] </li></ul> |[Main xcNFT readme](https://github.com/paraspell-research/xcnft-pallet/blob/main/README.md), [xcNFT pallet_nfts readme](https://github.com/paraspell-research/xcnft-pallet/tree/main/xcnft-pallet_nfts), [xcNFT pallet_uniques readme](https://github.com/paraspell-research/xcnft-pallet/blob/main/xcnft-pallet_uniques/README.md), [official documentation](https://paraspell-research.github.io/xcnft-docs/)|  | 
-| 0c.  | Testing guide | <ul><li>[x] </li></ul> | [Testing guide in readme](https://github.com/paraspell-research/xcnft-pallet/blob/main/README.md#testing-pallet-functionality-), [Testing guide in docs](https://paraspell-research.github.io/xcnft-docs/implementation-guide/introduction.html#testing-pallet-functionality-%F0%9F%94%8E), [Unit tests commit](https://github.com/paraspell-research/xcnft-pallet/commit/c6682ecdf2fe9fdc51a678b028d77a0a4e33efa6) |  | 
+| 0b.  | Documentation | <ul><li>[x] </li></ul> |[Main xcNFT readme](https://github.com/paraspell-research/xcnft-pallet/blob/main/README.md), [xcNFT pallet_nfts readme](https://github.com/paraspell-research/xcnft-pallet/tree/main/xcnft-pallet_nfts), [xcNFT pallet_uniques readme](https://github.com/paraspell-research/xcnft-pallet/blob/main/xcnft-pallet_uniques/README.md), [official documentation](https://paraspell-research.github.io/xcnft-docs/)| Great docs | 
+| 0c.  | Testing guide | <ul><li>[x] </li></ul> | [Testing guide in readme](https://github.com/paraspell-research/xcnft-pallet/blob/main/README.md#testing-pallet-functionality-), [Testing guide in docs](https://paraspell-research.github.io/xcnft-docs/implementation-guide/introduction.html#testing-pallet-functionality-%F0%9F%94%8E), [Unit tests commit](https://github.com/paraspell-research/xcnft-pallet/commit/c6682ecdf2fe9fdc51a678b028d77a0a4e33efa6) | Good coverage | 
 | 0d.  | Docker | <ul><li>[x] </li></ul> | [Docker guide](https://github.com/paraspell-research/xcnft-pallet/blob/main/README.md#dockerized-local-testnet-build), [Docker image](https://github.com/paraspell-research/xcnft-pallet/blob/main/Dockerfile)|  | 
-| 0e. | Article | <ul><li>[x] </li></ul> |[Medium article link](https://medium.com/@dudo50/pallet-agnostic-cross-chain-nft-pallet-for-polkadot-paraverse-10a18a31b8ea) |  | 
-| 1. | xcNFT Abstract collection/NFT selection logic | <ul><li>[x] </li></ul> | [Commit adding abstracted collection and nft logic of xcNFT pallet_nfts version](https://github.com/paraspell-research/xcnft-pallet/commit/99a1202fd258c5bc085e4f200af4475b3690bd18), [Commit adding abstracted collection and nft logic of xcNFT pallet_uniques version](https://github.com/paraspell-research/xcnft-pallet/commit/447c7fc9bb84c47ab5a0f2171e4306270dfa67f5) |  | 
-| 2. | xcNFT Refactor | <ul><li>[x] </li></ul> | [Commit adding refactored code of xcNFT pallet_nfts version](https://github.com/paraspell-research/xcnft-pallet/commit/99a1202fd258c5bc085e4f200af4475b3690bd18), [Commit adding refactored code of xcNFT pallet_uniques version](https://github.com/paraspell-research/xcnft-pallet/commit/447c7fc9bb84c47ab5a0f2171e4306270dfa67f5) |  | 
-| 3. | xcNFT Benchmark | <ul><li>[x] </li></ul> | [Commit adding benchmarks and weights.rs files to the xcNFT](https://github.com/paraspell-research/xcnft-pallet/commit/62d30f13f3619532c0070f07882f27b3948d54d7) |  | 
-| 4.a | xcNFT Github Pages Docs I | <ul><li>[x] </li></ul> | [Commit adding developer guide documentation](https://github.com/paraspell-research/xcnft-docs/commit/cfad76685843cea4ec0777bea33ea08dc4388b83)|  | 
-| 4.b | xcNFT Github Pages Docs II | <ul><li>[x] </li></ul> | [Commit adding user guide documentation](https://github.com/paraspell-research/xcnft-docs/commit/58cb122c13675c23332c13bfd182ef63c6678228) |  | 
+| 0e. | Article | <ul><li>[x] </li></ul> |[Medium article link](https://medium.com/@dudo50/pallet-agnostic-cross-chain-nft-pallet-for-polkadot-paraverse-10a18a31b8ea) | Well-written article | 
+| 1. | xcNFT Abstract collection/NFT selection logic | <ul><li>[x] </li></ul> | [Commit adding abstracted collection and nft logic of xcNFT pallet_nfts version](https://github.com/paraspell-research/xcnft-pallet/commit/99a1202fd258c5bc085e4f200af4475b3690bd18), [Commit adding abstracted collection and nft logic of xcNFT pallet_uniques version](https://github.com/paraspell-research/xcnft-pallet/commit/447c7fc9bb84c47ab5a0f2171e4306270dfa67f5) | Works | 
+| 2. | xcNFT Refactor | <ul><li>[x] </li></ul> | [Commit adding refactored code of xcNFT pallet_nfts version](https://github.com/paraspell-research/xcnft-pallet/commit/99a1202fd258c5bc085e4f200af4475b3690bd18), [Commit adding refactored code of xcNFT pallet_uniques version](https://github.com/paraspell-research/xcnft-pallet/commit/447c7fc9bb84c47ab5a0f2171e4306270dfa67f5) | Works | 
+| 3. | xcNFT Benchmark | <ul><li>[x] </li></ul> | [Commit adding benchmarks and weights.rs files to the xcNFT](https://github.com/paraspell-research/xcnft-pallet/commit/62d30f13f3619532c0070f07882f27b3948d54d7) | Successful | 
+| 4.a | xcNFT Github Pages Docs I | <ul><li>[x] </li></ul> | [Commit adding developer guide documentation](https://github.com/paraspell-research/xcnft-docs/commit/cfad76685843cea4ec0777bea33ea08dc4388b83)| Good | 
+| 4.b | xcNFT Github Pages Docs II | <ul><li>[x] </li></ul> | [Commit adding user guide documentation](https://github.com/paraspell-research/xcnft-docs/commit/58cb122c13675c23332c13bfd182ef63c6678228) | Good | 
 
 # General Notes
 
@@ -299,3 +299,4 @@ Great job as usual guys. All unit tests are passing, and everything works as exp
 ```
 </details>
 
+`cargo test` kept running out of disk space for me even after upping it. But it almost completely compiled. See https://github.com/w3f/Grant-Milestone-Delivery/pull/1220#issuecomment-2485118077