DAOsign M1 eval (#1140)

evaluations/DAOsign_m1_PieWol.md

@@ -0,0 +1,95 @@
+# Evaluation
+
+
+- **Status:** accepted
+- **Application Document:** https://github.com/w3f/Grants-Program/blob/master/applications/DAOsign.md
+- **Milestone:** 1
+- **Previously successfully merged evaluation:** All by PieWol
+
+
+
+| Number | Deliverable               |  Accepted |Link                                                                                                                   | Evaluation Notes                                                      |
+|--------|---------------------------| ----- |------------------------------------------------------------------------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------|
+| 0a.    | License                   | <ul><li>[x] </li></ul> |  [LICENSE](https://github.com/DAOsign/polkadot-smart-contracts/blob/main/LICENSE)                                                                                                                      | Apache 2.0                                                                                                                                              |
+| 0b.    | Documentation             | <ul><li>[x] </li></ul> | [Autogenerated documentation](https://daosign.github.io/polkadot-smart-contracts/), [Readme](https://github.com/DAOsign/polkadot-smart-contracts?tab=readme-ov-file#overview)                                                                                                                    | good |
+| 0c.    | Testing and Testing Guide | <ul><li>[x] </li></ul> |         https://github.com/DAOsign/polkadot-smart-contracts?tab=readme-ov-file#testing   |   works           |
+| 0d.    | Docker                    |  <ul><li>[x] </li></ul> | https://github.com/DAOsign/polkadot-smart-contracts?tab=readme-ov-file#with-docker |  works                                                            |
+| 0e.    | Article                   | <ul><li>[x] </li></ul> | https://medium.com/@daosign/daosign-smart-signature-protocol-is-now-secured-with-polkadot-smart-contracts-387f3f3d9d17 | ok                                                                                         |
+| 1.     | Smart Contracts           |   <ul><li>[x] </li></ul> | https://github.com/DAOsign/polkadot-smart-contracts/tree/main/contracts                                         |   ok  |
+
+
+## General Notes
+Thanks for introducing the requested changes for more reusability of your smart contracts.
+
+
+
+## Testing
+ink! unit tests are passing.
+
+<details open>
+<summary>ink! eip unit tests</summary>
+<br>
+
+````````
+running 8 tests
+test daosign_eip712::tests::constructor ... ok
+test daosign_eip712::tests::hash_proof_of_signature ... ok
+test daosign_eip712::tests::hash_proof_of_authority ... ok
+test daosign_eip712::tests::hash_proof_of_agreement ... ok
+test daosign_eip712::tests::recover_proof_of_signature ... ok
+test daosign_eip712::tests::recover_proof_of_agreement ... ok
+test daosign_eip712::tests::recover_proof_of_authority ... ok
+test daosign_eip712::tests::recover ... ok
+
+test result: ok. 8 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
+
+   Doc-tests daosign_eip712
+
+running 0 tests
+
+test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
+````````
+</details>
+
+<details open>
+<summary>ink! unit tests</summary>
+<br>
+
+```
+running 6 tests
+test daosign_app::tests::test_get_proof_of_authority ... ok
+test daosign_app::tests::test_get_proof_of_agreement ... ok
+test daosign_app::tests::test_get_proof_of_signature ... ok
+test daosign_app::tests::test_store_proof_of_authority ... ok
+test daosign_app::tests::test_store_proof_of_agreement ... ok
+test daosign_app::tests::test_store_proof_of_signature ... ok
+
+test result: ok. 6 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.02s
+
+   Doc-tests daosign_app
+
+running 0 tests
+
+test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
+```
+</details>
+
+
+<details open>
+<summary>docker test output </summary>
+<br>
+
+```
+> [email protected] test
+> npx mocha --config .mocharc.json
+
+
+
+  DAOsignApp Tests
+    Lifecycle
+      ✔ #1 (225ms)
+
+
+  1 passing (3s)
+```
+</details>