benchmarks not passing

evaluations/PoCS_2_PieWol.md

@@ -12,43 +12,46 @@
 | ------ | ----------- | :------: | ---- |----------------- |
 |0a.|License| <ul><li>[x] </li></ul> | [Apache 2.0](https://github.com/auguth/pocs/blob/master/LICENSE) | - |
 |0b.|Documentation| <ul><li>[x] </li></ul> | [Pallet Contracts](https://auguth.github.io/pocs/target/doc/pallet_contracts/) , [Pallet Staking](https://auguth.github.io/pocs/target/doc/pallet_staking/) | okay |
-|0c.|Testing Guide | <ul><li>[ ] </li></ul> | [Testing guide](https://github.com/auguth/pocs/blob/master/TESTING-GUIDE.md) | nice, changes were good. Sadly tests themselves are **not** passing.|
+|0c.|Testing Guide | <ul><li>[ ] </li></ul> | [Testing guide](https://github.com/auguth/pocs/blob/master/TESTING-GUIDE.md) | nice, changes were good. benchmarks are not passing.|
 |0d.|Docker | <ul><li>[x] </li></ul> | [Dockerfile](https://github.com/auguth/pocs/blob/master/Dockerfile) , [Docker Compose](https://github.com/auguth/pocs/blob/master/docker-compose.yml) , [DockerImage Pull](https://github.com/auguth/pocs/blob/master/README.md#docker-pull)| docker works |
-|0e.| Article | <ul><li>[ ] </li></ul> | [Article (Draft)](https://github.com/auguth/pocs/blob/master/ARTICLE.md)|Good start. The article should be about changes just for this milestone and separately published. It's a delivery of M2. Just keep it in scope and concise. |
-|1.| Modify pallet staking for PoCS |<ul><li>[ ] </li></ul> | [PoCS x NPoS (Milestone 2 - Core) PR#29](https://github.com/auguth/pocs/pull/29)| Changes to min bond are not ok. |
+|0e.| Article | <ul><li>[x] </li></ul> | [Article (Draft)](https://github.com/auguth/pocs/blob/master/ARTICLE.md)| okay |
+|1.| Modify pallet staking for PoCS |<ul><li>[ ] </li></ul> | [PoCS x NPoS (Milestone 2 - Core) PR#29](https://github.com/auguth/pocs/pull/29)| Thanks for changing to a minimum stake score. please check the benchmarks.|
 
 ## General Notes
-Building throws lots of warnings. e.g. about dead code. Any reason why you haven't fixed those?
+Thank you for the changes you have introduced. The article is now focussed on this very milestone.
 
-## Min Bond
-I think what you did here is a major problem for the NPoS algorithm. The min bond is vital to ensure a reasonable runtime of the algorithm. Otherwise it might not finish within the given blocktime. This is a major issue and you should think of a solution.
+There is still a lot of warnings emitted on compilation which are really easy to fix.
 
-I'm referring to 
-```
-			if value < T::Currency::minimum_balance() {
-				return Err(Error::<T>::InsufficientBond.into())
-			}
-			// if value < T::Currency::minimum_balance() {
-			// 	return Err(Error::<T>::InsufficientBond.into())
-			// }
-```
-which are changes you made in `pallets/staking/src/pallet/mod.rs`
+## Tests pallet-staking
+All regular tests are passing. Runtime benchmarks are throwing some errors.
 
-Looking forward to your comments or a solution on this.
+<details>
 
-## Tests pallet-staking
-testing results in a bunch of errors regarding corrupted state. You seem to push a bounded vec beyond its limits. 
+	error[E0046]: not all trait items implemented, missing: `score_update_worst_case`
+		--> /root/pocs/pallets/staking/src/pallet/impls.rs:1429:1
+		|
+	1429 | impl<T: Config> SortedListProvider<T::AccountId> for UseValidatorsMap<T> {
+		| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `score_update_worst_case` in implementation
+		|
+		= help: implement the missing item: `fn score_update_worst_case(_: &<T as frame_system::Config>::AccountId, _: bool) -> <Self as frame_election_provider_support::SortedListProvider<<T as frame_system::Config>::AccountId>>::Score { todo!() }`
+
+	error[E0046]: not all trait items implemented, missing: `score_update_worst_case`
+		--> /root/pocs/pallets/staking/src/pallet/impls.rs:1495:1
+		|
+	1495 | impl<T: Config> SortedListProvider<T::AccountId> for UseNominatorsAndValidatorsMap<T> {
+		| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `score_update_worst_case` in implementation
+		|
+		= help: implement the missing item: `fn score_update_worst_case(_: &<T as frame_system::Config>::AccountId, _: bool) -> <Self as frame_election_provider_support::SortedListProvider<<T as frame_system::Config>::AccountId>>::Score { todo!() }`
+
+	For more information about this error, try `rustc --explain E0046`.
+	warning: `pallet-staking` (lib) generated 1 warning
+	error: could not compile `pallet-staking` (lib) due to 2 previous errors; 1 warning emitted
+</details>
 
-```
-ERROR frame_support::storage: (key, value) failed to decode at [95, 62, 73, 7, 247, 22, 172, 137, 182, 52, 125, 21, 236, 236, 237, 202, 156, 106, 99, 127, 98, 174, 42, 241, 199, 227, 30, 237, 126, 150, 190, 4, 175, 78, 224, 83, 28, 218, 230, 17, 71, 0, 0, 0, 0, 0, 0, 0]: Error { cause: Some(Error { cause: None, desc: "BoundedVec exceeds its limit" }), desc: "Could not decode `Nominations::targets`" } 
-``` 
 
 ## Testing Guide
-nice updates. Looks good now. I think even the commit history can safely be removed from this. The rest it good the way it is.
+Great simplification of the testing guide!
+
 
-## Article deliverable
-Please stick to the agreed upon deliverables and publish an actual article even for this milestone. 
-With the amount of content you included in your draft I don't see it making a lot of sense to wait for M3 results to write an even larger article. The article should be a concise presentation and explanation of your concept and accomplishments for this milestone only. I doubt many readers will make the effort to read such a detailed long article. No offense to you and I appreciate the work you put into it. 
 
-A short summary of previous change could make sense in article for m3 to give readers an impression of your work with just one article.