WAI website update 2024-11-18 #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
✅ Deploy Preview for wai-wcag-act-rules ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I would like background and rational for this change. Thanks. |
…gation" [0ssw9k]: scrollable regions pass when there is an open modal (#2219) * scrollable regions should pass when there is an open modal - updated expectation to exclude inert elements from sequential focus - added passing example * Update _rules/scrollable-element-keyboard-accessible-0ssw9k.md Co-authored-by: Jean-Yves Moyen <[email protected]> * Update scrollable-element-keyboard-accessible-0ssw9k.md --------- Co-authored-by: Jean-Yves Moyen <[email protected]> Co-authored-by: Wilco Fiers <[email protected]>
Co-authored-by: Carlos Duarte <[email protected]>
* Update to rules format 1.1 * Update mention to rules format from 1.0 to 1.1 in rule design * Update pages/design/rule-design.md --------- Co-authored-by: Carlos Duarte <[email protected]>
shawna-slh
previously approved these changes
Nov 24, 2024
There was a problem hiding this comment.
From a quick skim, I don't see anything that I need to review. So I leave it to @daniel-montalvo and @remibetin to do the QA check. Thanks!
* Tweak image-description rule * Update _rules/image-button-non-empty-accessible-name-59796f.md Co-authored-by: sage-putnam <[email protected]> --------- Co-authored-by: sage-putnam <[email protected]>
|
This is mainly about updating the existing rules to the new ACT Rules Format 1.1 |
daniel-montalvo
previously approved these changes
Nov 25, 2024
remibetin
reviewed
Nov 27, 2024
There was a problem hiding this comment.
The last commit was pushed after Shawn's review and contains substantive content.
I leave it to Shawn to review before publication.
… after Shawn's review This reverts commit 13a68de.
|
@daniel-montalvo Published, please QA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to publish ACT content to the WAI website.