Skip to content

Commit

Permalink
Text spacing rewrite (#1923)
Browse files Browse the repository at this point in the history 
* Add new letter-spacing rule and deprecate old one

* Add new word-spacing rule and deprecate old one

* Clean up assumptions

* Clean up

* Clean up

* Add new line-height rule and deprecate old one

* Replace old letter spacing version rather than deprecating it

* Replace old line height version rather than deprecating it

* Replace old word spacing version rather than deprecating it

* Target text nodes

* Improve background note

* Apply suggestion from review

* Clean up

* Target text nodes rather than their parents

* Target text nodes rather than their parents

* Add missing reference

* Update example

* Apply to parent of text nodes, not text nodes

* Apply suggestions from code review

Co-authored-by: Carlos Duarte <[email protected]>

* Typos

Co-authored-by: Carlos Duarte <[email protected]>

* Typos

---------

Co-authored-by: Carlos Duarte <[email protected]>
  • Loading branch information
@WilcoFiers
WilcoFiers and Carlos Duarte committed Oct 13, 2023
1 parent 1a79734 commit e44aa82
Show file tree
Hide file tree
Showing 25 changed files with 991 additions and 1,359 deletions.
1,959 changes: 701 additions & 1,258 deletions content-assets/wcag-act-rules/testcases.json
View file

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion content-assets/wcag-act-rules/testcases/24afc2/1877242970bb7a92b5c8ee7bc5c5e5ec87877890.html
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>Passed Example 1</title>
<title>Inapplicable Example 7</title>
</head>
<body>
<p style="letter-spacing: 0.1em">
Expand Down
2 changes: 1 addition & 1 deletion content-assets/wcag-act-rules/testcases/24afc2/43f8fe88b8e7365db7aa251b263b5d00c7a47ae9.html
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>Passed Example 3</title>
<title>Passed Example 2</title>
</head>
<body>
<style>
Expand Down
2 changes: 1 addition & 1 deletion content-assets/wcag-act-rules/testcases/24afc2/64b25817b3d3909ab7f4acaee061875ebac1cee3.html
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>Passed Example 8</title>
<title>Inapplicable Example 9</title>
</head>
<body>
<p style="letter-spacing: 0.1em">
Expand Down
2 changes: 1 addition & 1 deletion content-assets/wcag-act-rules/testcases/24afc2/6aa2034507dc16e6ae0d16f1b6f2a14d3dfadc18.html
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>Passed Example 7</title>
<title>Inapplicable Example 8</title>
</head>
<body>
<p style="letter-spacing: 0.1em">
Expand Down
2 changes: 1 addition & 1 deletion content-assets/wcag-act-rules/testcases/24afc2/787f24a573fa422e24ab72312f7306253bb83a4f.html
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>Passed Example 4</title>
<title>Passed Example 3</title>
</head>
<body>
<p style="letter-spacing: 0.1em !important; letter-spacing: 0.15em !important">
Expand Down
2 changes: 1 addition & 1 deletion content-assets/wcag-act-rules/testcases/24afc2/88d6ea5706ed8ae188caa166879c381e64e5077a.html
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>Inapplicable Example 3</title>
<title>Inapplicable Example 4</title>
</head>
<body>
<p style="position: absolute; top: -999em; letter-spacing: 0.1em !important;">
Expand Down
2 changes: 1 addition & 1 deletion content-assets/wcag-act-rules/testcases/24afc2/92e706402d8f8cb13d73ffb759ce35ec910d272c.html
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>Inapplicable Example 4</title>
<title>Inapplicable Example 5</title>
</head>
<body>
<p style="width: 60%">
Expand Down
2 changes: 1 addition & 1 deletion content-assets/wcag-act-rules/testcases/24afc2/9608b535262c655f523314958f8ca3019a0968fe.html
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>Passed Example 6</title>
<title>Inapplicable Example 6</title>
</head>
<body>
<style>
Expand Down
9 changes: 9 additions & 0 deletions content-assets/wcag-act-rules/testcases/24afc2/9af5662e9957191c22c558a1a8511bae709a2b36.html
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>Inapplicable Example 2</title>
</head>
<body>
<div style="letter-spacing: 0.1em !important;"></div>
</body>
</html>
2 changes: 1 addition & 1 deletion content-assets/wcag-act-rules/testcases/24afc2/9e9382901f59c7dd476717a55bf5c5a37ed76bbc.html
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>Passed Example 2</title>
<title>Passed Example 1</title>
</head>
<body>
<p style="letter-spacing: 0.15em !important">
Expand Down
2 changes: 1 addition & 1 deletion content-assets/wcag-act-rules/testcases/24afc2/be174e053a61ece650873a6a44f8e4be356e4193.html
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>Inapplicable Example 2</title>
<title>Inapplicable Example 3</title>
</head>
<body>
<p style="display: none; letter-spacing: 0.1em !important;">
Expand Down
13 changes: 13 additions & 0 deletions content-assets/wcag-act-rules/testcases/24afc2/cabfcae45afac141b38fd9cac2e07a64fb6b9896.html
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>Passed Example 5</title>
</head>
<body>
<div style="font-size: 16px; letter-spacing: 2px !important">
<p style="font-size: 10px;">
The toy brought back fond memories of being lost in the rain forest.
</p>
</div>
</body>
</html>
13 changes: 13 additions & 0 deletions content-assets/wcag-act-rules/testcases/24afc2/d6d5bf7c081939e64d10022dd29f5e31d2153d50.html
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>Passed Example 6</title>
</head>
<body>
<div style="letter-spacing: 0.1em !important">
<p style="letter-spacing: 0.2em !important;">
The toy brought back fond memories of being lost in the rain forest.
</p>
</div>
</body>
</html>
2 changes: 1 addition & 1 deletion content-assets/wcag-act-rules/testcases/24afc2/f000a9c495f11a4a11a4314871b91f4173e4589a.html
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>Passed Example 5</title>
<title>Passed Example 4</title>
</head>
<body>
<p style="letter-spacing: 0.15em !important; letter-spacing: 0.1em">
Expand Down
9 changes: 9 additions & 0 deletions content-assets/wcag-act-rules/testcases/78fd32/0128de1beb7862298366680f6920bd3b3874d752.html
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>Inapplicable Example 2</title>
</head>
<body>
<div style="line-height: 0.1em !important;"></div>
</body>
</html>
13 changes: 13 additions & 0 deletions content-assets/wcag-act-rules/testcases/78fd32/317de3cc2f864ebdae6e325c9fbc0dbf4947c5c9.html
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>Passed Example 8</title>
</head>
<body>
<div style="letter-spacing: 1em !important">
<p style="letter-spacing: 1.5em !important; max-width: 200px;">
The toy brought back fond memories of being lost in the rain forest.
</p>
</div>
</body>
</html>
13 changes: 13 additions & 0 deletions content-assets/wcag-act-rules/testcases/78fd32/78034759a1086c7ffa8037b6e6e2327ece4a19d7.html
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>Passed Example 7</title>
</head>
<body>
<div style="font-size: 16px; line-height: 15px !important">
<p style="font-size: 10px; max-width: 200px;">
The toy brought back fond memories of being lost in the rain forest.
</p>
</div>
</body>
</html>
13 changes: 13 additions & 0 deletions content-assets/wcag-act-rules/testcases/9e45ec/15905a239d6755102be6a60aa152ad963d5b1dbb.html
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>Passed Example 5</title>
</head>
<body>
<div style="font-size: 16px; word-spacing: 2px !important">
<p style="font-size: 10px;">
The toy brought back fond memories of being lost in the rain forest.
</p>
</div>
</body>
</html>
13 changes: 13 additions & 0 deletions content-assets/wcag-act-rules/testcases/9e45ec/8d2baed183149375922c23a9a5f42b52b627d713.html
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>Passed Example 6</title>
</head>
<body>
<div style="word-spacing: 0.1em !important">
<p style="word-spacing: 0.2em !important;">
The toy brought back fond memories of being lost in the rain forest.
</p>
</div>
</body>
</html>
9 changes: 9 additions & 0 deletions content-assets/wcag-act-rules/testcases/9e45ec/fdd3c30f28464b32eb8a1397f70a41dfd3b2cb1c.html
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<!DOCTYPE html>
<html lang="en">
<head>
<title>Inapplicable Example 2</title>
</head>
<body>
<div style="word-spacing: 0.1em !important;"></div>
</body>
</html>
Loading

0 comments on commit e44aa82

Please sign in to comment.