-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add refresh
status purpose.
#185
base: main
Are you sure you want to change the base?
Conversation
<td>`refresh`</td> | ||
<td> | ||
Used to signal that an updated [=verifiable credential=] is available via the | ||
credential's <a data-cite="VC-DATA-MODEL-2.0#refreshing">Refresh service</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lowercase?
credential's <a data-cite="VC-DATA-MODEL-2.0#refreshing">Refresh service</a> | |
credential's <a data-cite="VC-DATA-MODEL-2.0#refreshing">refresh service</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new property should be added, I presume, to the bitstring vocabulary document, and to the diagram include therein.
It is o.k. if this is handled in a separate Issue+PR, but it ought to be done. Please raise an issue if you prefer to handle it separately.
Similarly, shouldn't the relevant context file be changed?
(I am happy to do the changes on the vocabulary... eventually. I am not at my computer right now, it would be difficult to do it on my tablet...)
Nope, it's not a term, it's an arbitrary string. :) |
I think we can have the purpose added and explore discussions around if it needs an additional defined property separately. I think if a new term needs to be defined it would be more towards an associated @msporny Would it be reasonable to add to this text that this refresh status doesn't have an effect on the validity of the current credential, meaning it doesn't become revoked because there's an update available, simply signals that there's an update. Revocation should still be managed by a separate status entry. If there's a "breaking update", the credential would get updated + revoked. If its a "soft" (meaning a minor change) or "additive"(adding a data element) update, the credential gets updated, but the consumer of the credential can still use the non updated version without concern (they don't need to get the updated version). If its also revoked then they would need to get the updated version if they want to continue using the data for their services. I think just a sentence that the refresh status doesn't invalidate the current credential. |
Except that it doesn't signal that there's an update. It signals that there's a place to ask for any update that might be available. |
@TallTed the purpose is that you would resolve the index of the refresh status, 0 means no update available and 1 means an update is available you MAY hit the refresh endpoint, so it does signal that there's an update available. The original purpose label was "supersession", meaning 0 means the credential isn't superseded, and 1 the credential has been superseded. The suggestion to make the purpose label A |
Oops, sorry. (For some reasons preview does not work, and I have only my ipad with me where I am this week, so it was difficult to see the exact context of the changes. My approval holds :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like this to address the comments?
<td> | ||
Used to signal that an updated [=verifiable credential=] is available via the | ||
credential's <a data-cite="VC-DATA-MODEL-2.0#refreshing">Refresh service</a> | ||
feature. This status is not reversible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feature. This status is not reversible. | |
feature. This status does not invalidate the [=verifiable credential=] and is not reversible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve this PR with the amended language it contains.
This PR is an attempt to address issue #183 by adding a
refresh
status purpose.💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Nov 24, 2024, 10:55 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 [Related URL]([object Object])
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.