Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add suggestion on how malicious issuers can be detected. #161
Add suggestion on how malicious issuers can be detected. #161
Changes from 1 commit
504d647
d5b4950
8bd3f39
7fb0dd2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry but I do not follow this. Assuming most holders only get a single credential from each issuer then how is this possible? Furthermore even if they obtain multiple credentials from one issuer, then it is unlikely they will all have the same unique identifiers in them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An individual holder (a user of holder software) is not expected to be able to do this, but holder software (that services multiple holders) potentially could. As an example, holder software could offer an opt-in tool that could perform this analysis across multiple holders and report back its findings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And which users are going to trust holder software that is shared by multiple users and that scans the wallets of multiple users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of them, I'd expect. Most people accept this kind of analysis from the most popular Web browsers, probably often without knowing it. Hopefully wallet providers will do better, especially when it is easier to provide alternatives (that don't do it at all) than it is to compete in the browser market.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you saying that web browsers scan a user's PC and converse between themselves about the contents? (as this is the scenario that you are proposing for wallets). If so, it surprises me, as I was not aware of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@David-Chadwick, @dlongley — Please pick up this thread below, following the suggestions I first made based on the thread above and then modified based on reactions from @David-Chadwick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TallTed, the text below looks ok to me modulo the change from "unique" to "shared" ... I'll comment down there on that.
@David-Chadwick,
I'm not implying anything as specific as "scan a user's PC", but rather, that some Web browsers (and some search engines) collect information based on your behavior and various inputs, aggregate it with information from other users, and send it somewhere for analysis, yes.