Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mechanism to retrieve historical status list information. #112

Merged
merged 7 commits into from
Jan 13, 2024

Conversation

msporny
Copy link
Member

@msporny msporny commented Dec 29, 2023

This PR is an attempt to address issue #94 by adding an optional normative mechanism to retrieve historical status list information.


Preview | Diff

Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepting this -- but haven't put much thought into the side effects (privacy considerations, so on) yet.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@decentralgabe decentralgabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this. it would be great to have an example query.

index.html Outdated
a valid URL-encoded [[XMLSCHEMA11-2]] dateTimeStamp string value. The result of
dereferencing such a timestamped URL MUST be a status list credential containing
either the status list as it existed at the given point in time, or a
<a href="#STATUS_RETRIEVAL_ERROR">STATUS_RETRIEVAL_ERROR</a>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider adding a sentence that says something like...

"Providing such a mechanism to dereference the status list as of a particular point in time lends itself to allowing for the functionality of determining as precise as possible timestamps of status changes, at the issuers discretion"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 804df0e.

Copy link
Contributor

@dmitrizagidulin dmitrizagidulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

index.html Outdated
Comment on lines 762 to 816
dereferencing such a timestamped URL MUST be a status list credential containing
either the status list as it existed at the given point in time, or a
<a href="#STATUS_RETRIEVAL_ERROR">STATUS_RETRIEVAL_ERROR</a>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dereferencing such a timestamped URL MUST be a status list credential containing
either the status list as it existed at the given point in time, or a
<a href="#STATUS_RETRIEVAL_ERROR">STATUS_RETRIEVAL_ERROR</a>.
dereferencing such a timestamp-parameterized URL MUST be a status list credential
containing either the status list as it existed at the given point in time, or a
<a href="#STATUS_RETRIEVAL_ERROR">STATUS_RETRIEVAL_ERROR</a>.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or

Suggested change
dereferencing such a timestamped URL MUST be a status list credential containing
either the status list as it existed at the given point in time, or a
<a href="#STATUS_RETRIEVAL_ERROR">STATUS_RETRIEVAL_ERROR</a>.
dereferencing such a timestamp-parameterized URL MUST be either a status list
credential containing the status list as it existed at the given point in time,
or a <a href="#STATUS_RETRIEVAL_ERROR">STATUS_RETRIEVAL_ERROR</a>.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in dfa5e31.

@iherman
Copy link
Member

iherman commented Jan 10, 2024

The issue was discussed in a meeting on 2024-01-10

  • no resolutions were taken
View the transcript

3.3. Add mechanism to retrieve historical status list information. (pr vc-bitstring-status-list#112)

See github pull request vc-bitstring-status-list#112.

Manu Sporny: request to retrieve historical status list.
… so option to add date-time to the request.
… some discussions about what to do if the issuer does not have the status list at the requested date-time.
… nobody has implemented this feature yet, so should we fully specify this feature or wait for implementation experience.

David Chadwick: We would like implementer feedback, but we shouldn't have a spec that has multiple options on the reply - that might be confusing to implementers. Select one option for the reply (when you don't have one, we should say you MUST/SHOULD return an error) vs. "it's up to implementers".

Manu Sporny: we can make this change.

@msporny
Copy link
Member Author

msporny commented Jan 13, 2024

Normative, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit 26aaaf5 into main Jan 13, 2024
1 of 2 checks passed
@msporny msporny deleted the msporny-bsl-history branch January 13, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants