Events post-processor: consolidate events that "babble" #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems possible to end up with events that bubble for some target interfaces but don't for other target interfaces, see discussion in: w3c/webref#1212 The post-processor already knew how to assign a bubbling flag per target interface because we make a distinction between interfaces that are in a bubbling tree and interfaces that are not. However, the post-processor did not know how to consolidate an entry that appears duplicated in the events extract because the underlying event bubbles in one case but not in the other. This update makes it able to consolidate these events (which I call "babbling" events because, hey, it's Friday evening). We still don't have post-processing tests but that seems to work fine on Webref data.
dontcallmedom
approved these changes
Apr 19, 2024
tidoust
added a commit
that referenced
this pull request
Apr 19, 2024
New feature: - Events post-processor: consolidate events that "babble" (#1546)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems possible to end up with events that bubble for some target interfaces but don't for other target interfaces, see discussion in: w3c/webref#1212
The post-processor already knew how to assign a bubbling flag per target interface because we make a distinction between interfaces that are in a bubbling tree and interfaces that are not.
However, the post-processor did not know how to consolidate an entry that appears duplicated in the events extract because the underlying event bubbles in one case but not in the other. This update makes it able to consolidate these events (which I call "babbling" events because, hey, it's Friday evening).
We still don't have post-processing tests but that seems to work fine on Webref data.