Add some caveats about changing the default hash algorithm #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on keeping the algorithm used along with any results. Fixes #176.
iherman
approved these changes
Oct 1, 2023
Co-authored-by: Ivan Herman <[email protected]>
dlongley
approved these changes
Oct 1, 2023
Co-authored-by: Dave Longley <[email protected]>
Co-authored-by: Dan Yamamoto <[email protected]>
msporny
reviewed
Oct 3, 2023
peacekeeper
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Agree with @msporny 's suggestion about the internal hash algorithm.
davidlehn
reviewed
Oct 4, 2023
Co-authored-by: Manu Sporny <[email protected]> Co-authored-by: Dan Yamamoto <[email protected]>
Co-authored-by: David I. Lehn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and advice on keeping the algorithm used along with any results.
(Note, when this PR is created, spec-prod is having some issues resolving aspects of the document, so the PR Preview link might show errors. This GitHack version may provide better results).
Fixes #176.
Preview | Diff