-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new webrtcCodec parameter to MediaCapabilitiesInfo #186
base: main
Are you sure you want to change the base?
Conversation
Generally looks good. See questions in #185 (posting there to increase visibility). |
@@ -867,6 +880,25 @@ spec: secure-contexts; urlPrefix: https://www.w3.org/TR/secure-contexts/ | |||
source has side effects such as enabling different encoding | |||
modules. | |||
</li> | |||
<li> | |||
If the user agent is able to encode the media represented by | |||
<var>configuration</var> and <var>configuration</var> has a type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we link "type" explicitly to a config member?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the "valid audio MIME type" and "valid video MIME type" from section 2.1.4 are probably good targets.
<ol> | ||
<li>Let <var>webrtc</var> be a | ||
{{WebRTCMediaCapabilitiesInfo}} dictionary.</li> | ||
<li>If audio is represented by <var>configuration</var>, set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly, can we link to something that explicitly determines "audio" and "video" types are being represented?
<ol> | ||
<li>Let <var>webrtc</var> be a | ||
{{WebRTCMediaCapabilitiesInfo}} dictionary.</li> | ||
<li>If audio is represented by <var>configuration</var>, set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments as above about determining audio and video is being represented the configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of suggestions...
I think we need this, now that we're using codec descriptions more in APIs. |
Discussed at today's WebRTC interim and this would probably help moving WebRTC piggy backing on Media Capabilities to expose codecs (instead of exposing all/most codecs). |
Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
Fixes #185
Preview | Diff
Preview | Diff