Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mandate security and privacy consideration section(s) #216

Closed
wants to merge 1 commit into from

Conversation

samuelweiler
Copy link
Member

resolving #131

Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svgeesus
Copy link
Contributor

svgeesus commented Jul 9, 2019

@ianbjacobs I like that wording, which would also resolve #144

@svgeesus
Copy link
Contributor

Also fixed by #268 which is to resolve #144

@samuelweiler
Copy link
Member Author

samuelweiler commented Jun 16, 2020

It's not clear to me that the template needs to go into detail about how editors organize those considerations into N sections.

For sec and privacy, I specifically want special sections. It's not clear to me that this needs to be in the charter - I'm fine stripping it out of the charter entirely. It's too verbose as it is.

Further, we want spec authors to do the consideration themselves - the section should not populated with review comments; it should be from the authors.

@samuelweiler
Copy link
Member Author

Instead resolved via #300, though that still uses "should"

@samuelweiler samuelweiler deleted the sec-considerations-must branch January 22, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants