Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[html-aam PR 484] contextual role concept proposal #2218
base: main
Are you sure you want to change the base?
[html-aam PR 484] contextual role concept proposal #2218
Changes from 20 commits
0efae20
3a79bf5
1eac627
57e27f4
310dd87
cc4bb80
b271e35
33e5dfa
1ebbfc5
da0865d
b1c7a8c
75b9bdd
4f54274
ea6a784
8dadb65
5a05613
b6997fb
15ec08e
0cca193
5ab29b0
b4d9fac
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recall we agreed to get rid of the expectation to computed orphaned generics, since doing it in the engine was sometimes costly and always irrelevant to the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should use a different example than listitem, here and above, given the push back on the orphan roles tests which is partially being discussed here: #2166
But started with the roll back of orphan
<li>
tests in WPT.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
orphan
li
elements was not where the pushback was. it was orphan<element role=listitem>
that had the pushback.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an FYI for related WPT files, any time you're tempted to add an orphaned role test, please add a comment that points to the appropriate orphaned-roles-specific test file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand it, it's still the same issue whether the role is implicit or explicit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tried to message you this in slack, but i'm thinking of closing this PR down, and instead taking the approach of just clarifying the few elements that do have contextual roles mapping tables