Implement the "not" condition support #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Mar 21, 2024
This CL changes WebIDL to support the not condition, and makes it tested. Since the not condition has not been written in the specification yet, it is implemented behind the flag. Explainer: https://github.com/WICG/service-worker-static-routing-api/blob/main/final-form.md Design Doc: https://docs.google.com/document/d/1B2D8w_2M4j9CZC1VccBOAhfCdiRP3yPCSV5UKKDhU70/ Specification: w3c/ServiceWorker#1711 Bug: 328565554 Change-Id: I0b50a26530e6aa273ef4b8c20181104ad5e3591c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5367792 Commit-Queue: Yoshisato Yanagisawa <[email protected]> Reviewed-by: Minoru Chikamune <[email protected]> Reviewed-by: Takashi Toyoshima <[email protected]> Reviewed-by: Kouhei Ueno <[email protected]> Cr-Commit-Position: refs/heads/main@{#1276118}
|
@domenic @sisidovski Will you take a look at the spec change? |
|
@mkruisselbrink Will you review this? |
|
@mkruisselbrink Do you have any concerns on this PR? Please feel free to point them out. |
mkruisselbrink
approved these changes
Apr 16, 2024
github-actions bot
added a commit
that referenced
this pull request
Apr 16, 2024
SHA: 8d64a5c Reason: push, by mkruisselbrink Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to asleekgeek/ServiceWorker
that referenced
this pull request
Apr 17, 2024
SHA: 8d64a5c Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a specification update on supporting the "not" condition, which is also written in
https://github.com/WICG/service-worker-static-routing-api/blob/main/final-form.md.
The "not" condition is used for reversing the condition inside for ease of writing a matching rule for a reversed condition.
Preview | Diff