Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove shorthand flag output on kubernetes #406

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Remove shorthand flag output on kubernetes #406

merged 1 commit into from
Feb 20, 2024

Conversation

optik-aper
Copy link
Member

@optik-aper optik-aper commented Feb 20, 2024 •
edited
Loading

Description

Resolve the crash because of overlapping on the -o flag shorthand on the kubernetes command.

Related Issues

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@optik-aper optik-aper added the regression Something that worked doesn't work after changes label Feb 20, 2024
@optik-aper optik-aper self-assigned this Feb 20, 2024
@github-actions GitHub Actions
Copy link

Unit Tests and Coverage

Show Output 
?   	github.com/vultr/vultr-cli/v3	[no test files]

Pusher: @optik-aper, Action: pull_request_target

mondragonfx
mondragonfx approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@mondragonfx mondragonfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@optik-aper optik-aper merged commit b84492f into vultr:master Feb 20, 2024
4 checks passed
@PaulSonOfLars PaulSonOfLars mentioned this pull request Feb 25, 2024
Closed
@optik-aper optik-aper mentioned this pull request Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mondragonfx mondragonfx mondragonfx approved these changes

Assignees

@optik-aper optik-aper

Labels
regression Something that worked doesn't work after changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@optik-aper @mondragonfx