Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination of API requests #128

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Pagination of API requests #128

merged 2 commits into from
Nov 26, 2024

Conversation

jasites
Copy link
Contributor

@jasites jasites commented Jul 19, 2024

Description

Create a wrapper around vultr_v2.api_query that handles pagination

Related Issues

Fixes #127

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@resmo : I'm going to run the integration tests against my account and verify everything works there, but review / feedback is greatly appreciated, since I haven't had a chance to verify the behavior with all services yet and the different vultr_v2.query* functions.

@resmo resmo self-requested a review July 29, 2024 16:58
Copy link
Collaborator

@resmo resmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good code wise

@jasites
Copy link
Contributor Author

jasites commented Nov 25, 2024

Many apologies for the extended delay here - I was waiting on internal communication regarding stability around the VPC2 modules for further testing. There will be news in this area forthcoming, but I'm not sure what I can share here yet.

I was able to test specific integration tests successfully with this change, so I feel better about merging this.

@jasites jasites marked this pull request as ready for review November 25, 2024 19:29
@jasites jasites merged commit 4588553 into vultr:main Nov 26, 2024
1 check passed
@jasites jasites deleted the issue-127 branch November 26, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] - Support pagination of API requests
2 participants