Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg.json test script #77

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

pkg.json test script #77

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
781d816
add a new test script in pkg.json
louisinger Oct 26, 2022
766c6a6
rename test:ci by "checks"
louisinger Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@
"nobuild:unit": "npm run mocha:ts -- --timeout 60000 'test/*.ts'",
"prettier": "prettier 'ts_src/**/*.ts' 'test/**/*.ts' --ignore-path ./.prettierignore",
"prettierjs": "prettier 'src/**/*.js' --ignore-path ./.prettierignore",
"test": "npm run build && npm run format:ci && npm run lint && npm run nobuild:coverage",
"checks": "npm run build && npm run format:ci && npm run lint && npm run nobuild:coverage",
"test": "npm run build && npm run nobuild:unit && npm run nobuild:integration",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"test": "npm run build && npm run nobuild:unit && npm run nobuild:integration",
"test": "npm run nobuild:unit && npm run nobuild:integration",

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@louisinger we should use these commands in the gh action.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@louisinger we should use these commands in the gh action.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to keep several steps in the GH actions, test is for local testing only @altafan

"unit": "npm run build && npm run nobuild:unit"
},
"repository": {
Expand Down