Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UB in impl VertexBufferCollection for Vec<Subbuffer<T>> #2577

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Fix UB in impl VertexBufferCollection for Vec<Subbuffer<T>> #2577

merged 1 commit into from
Oct 16, 2024

Conversation

marc0246
Copy link
Contributor

Vec is #[repr(Rust)]... oopsie.

Changelog:

### Bugs fixed
- Fixed UB in `impl VertexBufferCollection for Vec<Subbuffer<T>>` where a `Vec` was being transmuted.

@marc0246 marc0246 changed the title Fix UB in impl VertexBufferCollection for Vec<Subbuffer<T>>` Fix UB in impl VertexBufferCollection for Vec<Subbuffer<T>> Oct 16, 2024
@Rua Rua merged commit d1a9314 into vulkano-rs:master Oct 16, 2024
6 checks passed
Rua added a commit that referenced this pull request Oct 16, 2024
@Rua
#2577 changelog
d62fbf3
@marc0246 marc0246 deleted the vertex-buffer-collection-ub branch October 16, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marc0246 @Rua