Fix UB in GenericMemoryAllocator::deallocate
#2572
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was UB for a two different reasons. First, the block pointer given out on allocation went through
Box::deref_mut
, which means that each new allocation made would invalidate pointers in previous allocations, in both SB and TB. Second, in SB, moving aBox
asserts uniqueness, which happens when sorting the vec containing the boxes.Sounds quite horrible, but thankfully, what's saving us is that
deallocate
is only ever called via dynamic dispatch unless you call it yourself. There's no way to take advantage of UB happening across dynamic dispatch calls.Changelog: