Memory allocator impl #2289
Merged
Memory allocator impl #2289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you please give |
|
Oh, I was actually looking for that impl earlier but couldn't find it. I'll be right on it 👍 |
|
Awesome, thanks! |
hakolao
pushed a commit
to hakolao/vulkano
that referenced
this pull request
Feb 20, 2024
* Make the impl of Arc for MemoryAllocator more generic * Make the impl of Arc for CommandBufferAllocator more generic * Make the impl of Arc for DescriptorSetAllocator more generic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to fix some problems with usability when creating a custom memory allocator. Simple scenario is creating a struct wrapping a
MemoryAllocatorWhen trying to create a
SubbufferAllocatorusing anArc<FooAllocator>it will not compile, becauseMemoryAllocatoris only implemented forArc<GenericMemoryAllocator<S>>. With these changesMemoryAllocatorwill be implemented for anyArc<T> where T: MemoryAllocator, making custom allocators easier to use.While I was at it I also added the same blanket implementation for the
CommandBufferAllocator.