Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2203 and another bug #2284

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Fix #2203 and another bug #2284

merged 1 commit into from
Aug 9, 2023

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Aug 9, 2023 •
edited
Loading

Changelog:

### Bugs fixed
- [#2203](https://github.com/vulkano-rs/vulkano/issues/2203): Shader reflection fails to find descriptor set variables if multiple `OpAccessChain` instructions are themselves chained.
- vulkano-shaders: Invalid emitted code for shader input/output interfaces if the shader is missing a name decoration.

Fixes #2203.

@marc0246
Copy link
Contributor

marc0246 commented Aug 9, 2023

Awesome!

@marc0246 marc0246 merged commit 5ca4805 into vulkano-rs:master Aug 9, 2023
3 checks passed
marc0246 added a commit that referenced this pull request Aug 9, 2023
@marc0246
#2284 changelog
e9081db
@Rua Rua deleted the 2203-fix branch October 25, 2023 14:24
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@Rua @hakolao
Fix vulkano-rs#2203 (vulkano-rs#2284)
74bf836
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@marc0246 @hakolao
vulkano-rs#2284 changelog
d6ad110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect automatic pipeline layout creation
2 participants
@Rua @marc0246