Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remaining old error types, other cleanup #2281

Merged
merged 6 commits into from
Aug 9, 2023
Merged

Remove remaining old error types, other cleanup #2281

merged 6 commits into from
Aug 9, 2023

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Aug 6, 2023

Removes the OomError and RequirementNotMet error types, replacing them with VulkanError and ValidationError respectively.

marc0246
marc0246 reviewed Aug 9, 2023
View reviewed changes
vulkano/src/query.rs Outdated Show resolved Hide resolved
@marc0246
Copy link
Contributor

marc0246 commented Aug 9, 2023

Right it was the one in the ImageCreateInfo validation. The other ones were not borked but I did find it odd to put a function name in the context regardless so I like this better.

@marc0246 marc0246 merged commit c0379fc into vulkano-rs:master Aug 9, 2023
3 checks passed
@Rua Rua deleted the validation-cleanup branch October 25, 2023 14:24
hakolao pushed a commit to hakolao/vulkano that referenced this pull request Feb 20, 2024
@Rua @marc0246 @hakolao
Remove remaining old error types, other cleanup (vulkano-rs#2281)
53da31e 
* Remove remaining old error types, other cleanup

* Fix

* Add and fix or_fun_call lints

* Update vulkano/src/query.rs

Co-authored-by: marc0246 <[email protected]>

* Fix slightly borked context messages

---------

Co-authored-by: marc0246 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc0246 marc0246 marc0246 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rua @marc0246