Apply BS3 data attribute mappings to added child elements too. #4176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved Bootstrap 3 compatibility layer to handle dynamically added content better by converting data attributes for child nodes of the added nodes as well.
demiankatz
approved these changes
Jan 3, 2025
|
I found time to run tests today; looking good! |
EreMaijala
added a commit
to NatLibFi/NDL-VuFind2
that referenced
this pull request
Jan 7, 2025
…d-org#4176) Improved Bootstrap 3 compatibility layer to handle dynamically added content better by converting data attributes for child nodes of the added nodes as well. (cherry picked from commit a3300c5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves Bootstrap 3 compatibility layer to handle dynamically added content better by converting data attributes for child nodes of the added nodes as well.