Feature: Icon Mixins #4031
Feature: Icon Mixins #4031
Conversation
There was a problem hiding this comment.
@crhallberg, I see that some tests are failing here -- is that a problem, or do the tests themselves need adjustment?
|
Do we want to target this to |
We can wait and see what @EreMaijala thinks... |
|
@crhallberg I think it might be better to leave bootstrap3 as is. Otherwise it just adds a bit more maintenance burden for anyone upgrading and still using bootstrap3 as their base theme. It's not a huge deal though, but I'm just thinking that all the theme-related changes already add quite a bit of work. |
|
That's a good point, @EreMaijala -- if we leave this until 11.0, then bootstrap3 will be deleted anyway and it will be less to deal with. :-) What do you think, @crhallberg? Are there changes here that are actively fixing a problem in the bootstrap5 theme, or is this more preventative? |
|
@demiankatz This is fixing some errors with the icon, since the classes are different from FA4 to FA6 (which BS5 uses). I used it as an excuse to create these mixins. If I was going to check every icon by hand, I may as well refactor, right? 😅 |
In that case, would the solution be to create a PR that just changes the existing icon configuration in the bootstrap5 theme to incorporate your fixes (which I assume can be copied and pasted from the mixin here) and target that against 10.1? Then we don't have major refactoring at the last minute before the release but we can benefit immediately from your research... and this work can be developed in a more leisurely way as we move toward 11.0. :-) |
This is a fix for a few Font Awesome 6 icons spun out of control. If this is too much too soon, I can do a smaller version of this for v10.1 but editing
bootstrap5/theme.config.php.