Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support SVGPath #243

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

imfenghuang
Copy link

πŸ”— Linked issue

#241

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

SVGPath related properties are not processed originally

  1. MotionProperties is defined includes SVGPathProperties, but does not process
  2. style supports process pathLength, pathSpacing, pathOffset
  3. pathLength always normalize to 1
  4. pathLength and pathSpacing to stroke-dasharray. stroke-dasharray = pathLength pathSpacing
    4.1 stroke-dasharray = pathLength pathSpacing. this support process dashes and gaps are two or same size, can't process that dashes and gaps of various sizes with an odd number of values, like 4,1,2 which is equivalent to [4,1,2,4,1,2]
  5. pathOffset to stroke-dashoffset
  6. tests and demo added

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant