feat(plugin-git): support changelog and improve performance #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11649116096Details
💛 - Coveralls |
Mister-Hope
requested changes
Nov 2, 2024
Mister-Hope
requested changes
Nov 3, 2024
|
Title should be something like
|
Mister-Hope
reviewed
Nov 3, 2024
| @@ -11,3 +12,26 @@ export const checkGitRepo = (cwd: string): boolean => { | |||
| return false | |||
| } | |||
| } | |||
|
|
|||
| export const checkGitRepoType = (cwd: string): GitType | null => { | |||
There was a problem hiding this comment.
You are creating a git repo with git init, so repo type is a bad name to me.
Also I am wondering if we should check the first remote if origin doesn't exist?
There was a problem hiding this comment.
If do it this way, we will need to execute multiple command lines here: first, use git remote to list all of them, then get the first one, and finally execute git remote get-url xxx.
Co-authored-by: Mister-Hope <[email protected]>
pengzhanbo
changed the title
plugin-git , support changelog of the page
|
my bad, infer not refer 😂 |
Mister-Hope
approved these changes
Nov 3, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
close #123).What is the purpose of this pull request?
Description
The current plugin executes three commands separately to obtain
createdTime,updatedTime, andcontributorsfor a single page. This results in even more command executions whenfilepathscontains multiple files, which is the main reason for the slow collection of git information.Additionally, the
contributorsinformation often leads to duplicate statistics because the username in the local git configuration may not be the same as the username on the git hosting service, resulting in the same user having multiple usernames.This PR makes the following updates and modifications:
A single command is executed per file to collect all git information.
Adds a
contributorConfigpreset for contributors' information, supporting alias mapping.Adds
avatarandurlinformation for contributors.Adds a
changelogfield to collect the change logs for the current page.Adds an
filterfield to control whether information is collected for pages globally.Adds
contributorsandchangeloginfrontmatterto control whether relevant information is collected for the current page.