Improve docs for base url for public assets #4302
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current docs seem to be very vague. The only thing they mention is this comment: ``` // if base is set, use /base/favicon.ico ``` I had know idea if this meant that I need to manually add the base prefix and how I would do it, or whether I have to specifically create a `/base` directory within my `/docs` folder Since there are many issues where people are confused about this (vuejs#1500, vuejs#3869, vuejs#1815, vuejs#827), I think this explanation belongs to the docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current docs seem to be very vague. The only thing they mention is this comment:
I had know idea if this meant that I need to manually add the base prefix and how I would do it, or whether I have to specifically create a
/basedirectory within my/docsfolderLinked Issues
Since there are many issues where people are confused about this (#1500, #3869, #1815, #827), I think this explanation belongs to the docs
Tip
The author of this PR can publish a preview release by commenting
/publishbelow.