-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(RouterView): avoid parent rerenders when possible #2082
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for vue-router canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2082 +/- ##
=======================================
Coverage 97.28% 97.29%
=======================================
Files 26 26
Lines 6077 6090 +13
Branches 836 836
=======================================
+ Hits 5912 5925 +13
Misses 162 162
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Hi @posva is this still relevant? Perf fixes are always good and I wonder if this fixes a bug I'm seeing ... |
✅ Deploy Preview for vue-router canceled.
|
commit: |
@Narretz can you try using the pkg-pr published version? |
@posva my problem was actually solved in a vue 3.5+ update |
Close #1701