Fix Source paths properties page background on MSW

vslavik · Feb 2, 2024 · f396b7b · f396b7b
1 parent 7dfb4d4
commit f396b7b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/src/propertiesdlg.cpp b/src/propertiesdlg.cpp
@@ -235,7 +235,6 @@ class PropertiesDialog::BasePathCtrl : public wxStaticText
                                                   wxST_ELLIPSIZE_MIDDLE | wxST_NO_AUTORESIZE)
     {
     #ifdef __WXMSW__
-        SetBackgroundColour(*wxWHITE);
         SetForegroundColour(wxColour("#58595C"));
     #endif
     }
@@ -257,8 +256,6 @@ class PropertiesDialog::PathsList : public wxPanel
     {
 #if defined(__WXOSX__)
         SetWindowVariant(wxWINDOW_VARIANT_SMALL);
-#elif defined(__WXMSW__)
-        SetBackgroundColour(*wxWHITE);
 #endif
 
         auto sizer = new wxBoxSizer(wxVERTICAL);
@@ -313,6 +310,7 @@ class PropertiesDialog::PathsList : public wxPanel
         m_list->Bind(wxEVT_CONTEXT_MENU, &PathsList::OnRightClick, this);
 
 #ifdef __WXMSW__
+        m_placeholder->SetBackgroundColour(m_list->GetBackgroundColour());
         m_list->Bind(wxEVT_SET_FOCUS, [=](wxFocusEvent& e){
             e.Skip();
             m_placeholder->Lower(); // move to the top in Z-order, above the list (yeah, really)

diff --git a/src/resources/properties.xrc b/src/resources/properties.xrc
@@ -192,7 +192,6 @@
                         <bitmap platform="mac"  stock_id="NSFollowLinkFreestandingTemplate"/>
                         <bitmap platform="unix" stock_id="folder-open@symbolic"/>
                         <bitmap platform="win"  stock_id="follow-link"/>
-                        <bg platform="win">#ffffff</bg>
                       </object>
                       <flag>wxRIGHT|wxTOP|wxALIGN_CENTER_VERTICAL</flag>
                       <border>5d</border>